Skip to content

Commit 7f73fa5

Browse files
kyrenakiatngfballiano
authored
Fixed implicit conversion from float to int in Mage_SalesRule_Model_Validator (#3345)
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com> Co-authored-by: Fabrizio Balliano <fabrizio.balliano@gmail.com>
1 parent a508ae5 commit 7f73fa5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

app/code/core/Mage/SalesRule/Model/Validator.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -465,10 +465,10 @@ public function process(Mage_Sales_Model_Quote_Item_Abstract $item)
465465
$discountAmount = $result->getDiscountAmount();
466466
$baseDiscountAmount = $result->getBaseDiscountAmount();
467467

468-
$percentKey = $item->getDiscountPercent();
469468
/**
470469
* Process "delta" rounding
471470
*/
471+
$percentKey = (string) $item->getDiscountPercent();
472472
if ($percentKey) {
473473
$delta = $this->_roundingDeltas[$percentKey] ?? 0;
474474
$baseDelta = $this->_baseRoundingDeltas[$percentKey] ?? 0;

0 commit comments

Comments
 (0)