Skip to content

Commit f506683

Browse files
committed
build: Add comprehensive clean targets and legacy cleanup
Improves build hygiene by ensuring all generated artifacts are removed during clean operations. Changes: * Global Clean: Added a top-level `clean-all` target in `mirth-build.xml` that cascades to all sub-projects. * Legacy Cleanup: Introduced `clean-legacy-dirs` target to remove obsolete directories (`junit-reports`, `code-coverage-reports`) ensuring developers do not view stale reports. * Deep Clean: Updated sub-project clean targets to include `${test_classes}` and `${build.dir}`, preventing stale class files from polluting subsequent builds. Signed-off-by: Tony Germano <tony@germano.name>
1 parent 63c2dff commit f506683

File tree

5 files changed

+43
-6
lines changed

5 files changed

+43
-6
lines changed

client/ant-build.xml

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,18 @@
6969
<property name="plugins.xsltstep" value="${extensions}/xsltstep" />
7070
</target>
7171

72-
<target name="clean" depends="init">
72+
<target name="clean" depends="init, clean-legacy-dirs">
7373
<delete dir="${classes}" />
74+
<delete dir="${test_classes}" />
7475
<delete dir="${dist}" />
76+
<delete dir="${setup}" />
77+
<delete dir="${build.dir}" />
78+
</target>
79+
80+
<target name="clean-legacy-dirs" depends="init">
81+
<delete dir="${basedir}/code-coverage-reports" />
82+
<delete dir="${basedir}/junit-reports" />
83+
<delete dir="${basedir}/junit-html" />
7584
</target>
7685

7786
<target name="compile" depends="clean, init">

command/build.xml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,19 @@
1212
unless:set="archive.entry.date" />
1313
</target>
1414

15-
<target name="clean" depends="init">
15+
<target name="clean" depends="init, clean-legacy-dirs">
1616
<delete dir="${classes}" />
1717
<delete dir="${build.dir}" />
1818
<delete dir="${dist}" />
1919
<delete dir="${test_classes}" />
2020
</target>
2121

22+
<target name="clean-legacy-dirs" depends="init">
23+
<delete dir="${basedir}/code-coverage-reports" />
24+
<delete dir="${basedir}/junit-reports" />
25+
<delete dir="${basedir}/junit-html" />
26+
</target>
27+
2228
<target name="compile" depends="clean, init">
2329
<mkdir dir="${classes}" />
2430
<javac srcdir="${src}" destdir="${classes}" debug="on" includeAntRuntime="false">

donkey/build.xml

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,20 @@
1212
<fail message="Required property archive.entry.date is not set"
1313
unless:set="archive.entry.date" />
1414
</target>
15-
16-
<target name="clean" depends="init">
15+
16+
<target name="clean" depends="init, clean-legacy-dirs">
1717
<delete dir="${classes}" />
18+
<delete dir="${test_classes}" />
1819
<delete dir="${setup}" />
20+
<delete dir="${build.dir}" />
1921
</target>
20-
22+
23+
<target name="clean-legacy-dirs" depends="init">
24+
<delete dir="${basedir}/code-coverage-reports" />
25+
<delete dir="${basedir}/junit-reports" />
26+
<delete dir="${basedir}/junit-html" />
27+
</target>
28+
2129
<target name="compile" depends="clean">
2230
<mkdir dir="${classes}" />
2331

server/build.xml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,17 +68,24 @@
6868
<property name="plugins.xsltstep" value="${extensions}/xsltstep" />
6969
</target>
7070

71-
<target name="clean" depends="init">
71+
<target name="clean" depends="init, clean-legacy-dirs">
7272
<delete dir="${logs}" />
7373
<mkdir dir="${logs}" />
7474

7575
<delete dir="${classes}" />
76+
<delete dir="${test_classes}" />
7677
<delete dir="${setup}" />
7778
<delete dir="${dist}" />
7879
<delete dir="${build.dir}" />
7980
<delete dir="${docs.javadocs}" />
8081
</target>
8182

83+
<target name="clean-legacy-dirs" depends="init">
84+
<delete dir="${basedir}/code-coverage-reports" />
85+
<delete dir="${basedir}/junit-reports" />
86+
<delete dir="${basedir}/junit-html" />
87+
</target>
88+
8289
<target name="compile" depends="clean, init, create-javadocs">
8390
<!-- compile the source -->
8491
<mkdir dir="${classes}" />

server/mirth-build.xml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -212,4 +212,11 @@
212212
<target name="build-custom" depends="init">
213213
<ant antfile="custom-extensions.xml" target="build" />
214214
</target>
215+
216+
<target name="clean-all" depends="init" >
217+
<ant antfile="${donkey}/build.xml" dir="${donkey}" target="clean" />
218+
<ant antfile="${client}/ant-build.xml" dir="${client}" target="clean" />
219+
<ant antfile="${server}/build.xml" dir="${server}" target="clean" />
220+
<ant antfile="${cli}/build.xml" dir="${cli}" target="clean" />
221+
</target>
215222
</project>

0 commit comments

Comments
 (0)