Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request >> Add RAW measurements recorder #91

Open
pi-null-mezon opened this issue Dec 11, 2017 · 2 comments
Open

Feature request >> Add RAW measurements recorder #91

pi-null-mezon opened this issue Dec 11, 2017 · 2 comments
Labels
enhancement An enhancement request

Comments

@pi-null-mezon
Copy link

pi-null-mezon commented Dec 11, 2017

Hello. It would be great if OpenHantek will allow to save RAW measurements on HDD. I have already implemented such a feature in the repo fork. May I make a pull request?

@davidgraeff
Copy link
Member

Seems like an addition that does not interfere with the rest of the code base. Would be awesome if you either could make this available or allow me to copy the DataRecorder class to the master branch. (I reorganized some files recently, a rebase might be difficult)

@pi-null-mezon
Copy link
Author

pi-null-mezon commented Dec 14, 2017

So, the DataRecorder's code resides here:

datarecorder.h
datarecorder.cpp

As I have created this class as QObject (not QThread) descendant it is important to move it into separate thread when an instance is created (example)

@davidgraeff davidgraeff added the enhancement An enhancement request label Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement request
Projects
None yet
Development

No branches or pull requests

2 participants