Does /usr/bin/env cause problems in docker containers with non-standard app users?

[taylordowns2000]

I'm still getting a spooky error on lightning:

NODE_PATH=./priv/openfn/lib PATH=./priv/openfn/bin:/app/erts-12.2.1/bin:/app/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
cmd:
core execute \
 -o /tmp/output-1654009907-7-3fgxeg.json
 -s /tmp/state-1654009907-7-f6usl6.json \
 -l \
 -e /tmp/expression-1654009907-7-9zc4q1.json \
sh: 1: core: not found

Two things jump out at me: first the language pack is blank (and that's likely a deployment/config issue with lightning) but second the NODE_PATH seems 👌 but we're getting an error (sh: 1: core: not found) that I'd expect to see if the NODE_PATH was not properly set. I can confirm this when I run the following commands by hand:

$ NODE_PATH=./priv/openfn/lib PATH=./priv/openfn/bin:/app/erts-12.2.1/bin:/app/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin core execute
core execute

run an expression

Options:
      --version          Show version number                           [boolean]
  -l, --language         resolvable language/adaptor path             [required]
  -e, --expression       target expression to execute                 [required]
  -s, --state            Path to initial state file.                  [required]
  -o, --output           Path to write output.
  -t, --test             test mode, no HTTP requests
      --nc, --noConsole  if set to true, removes console.log for security
      --help             Show help                                     [boolean]

Examples:
  core execute -l salesforce -e foo.js -s   Using the salesforce language pack,
  state.json                                execute foo.js to STDOUT

Missing required arguments: language, expression, state
$ core execute
/bin/sh: 3: core: not found

@stuartc , is it possible that Rambo isn't respecting the NODE_PATH stuff because it's expecting something to be accessible first in /usr/bin/env?

engine/lib/engine/shell_runtime.ex

Line 31 in e1add41

"/usr/bin/env",

[taylordowns2000]

@stuartc , while this is fixed for Lightning, do we still want to address this (and/or some potential finicky path stuff) on Engine?