Apply java 17 best praticles

Author: velo

querydsl-libraries/querydsl-collections/src/main/java/com/querydsl/collections/DefaultQueryEngine.java

@@ -163,8 +163,8 @@ private List evaluateSingleSource(
     final List<Expression<?>> sources = Collections.<Expression<?>>singletonList(source);
     final Iterable<?> iterable = iterables.values().iterator().next();
     List<?> list;
-    if (iterable instanceof List) {
-      list = (List) iterable;
+    if (iterable instanceof List<?> list1) {
+      list = list1;
     } else {
       list = IteratorAdapter.asList(iterable.iterator());
     }

querydsl-libraries/querydsl-collections/src/main/java/com/querydsl/collections/MultiComparator.java

@@ -45,8 +45,8 @@ public MultiComparator(Evaluator<Object[]> ev, boolean[] directions, boolean[] n
 
   @Override
   public int compare(T o1, T o2) {
-    if (o1 instanceof Object[]) {
-      return innerCompare(ev.evaluate((Object[]) o1), ev.evaluate((Object[]) o2));
+    if (o1 instanceof Object[] objects) {
+      return innerCompare(ev.evaluate(objects), ev.evaluate((Object[]) o2));
     } else {
       return innerCompare(ev.evaluate(o1), ev.evaluate(o2));
     }

querydsl-libraries/querydsl-core/src/main/java/com/querydsl/core/BooleanBuilder.java

@@ -113,8 +113,8 @@ public BooleanBuilder clone() throws CloneNotSupportedException {
   public boolean equals(Object o) {
     if (o == this) {
       return true;
-    } else if (o instanceof BooleanBuilder) {
-      return Objects.equals(((BooleanBuilder) o).getValue(), predicate);
+    } else if (o instanceof BooleanBuilder builder) {
+      return Objects.equals(builder.getValue(), predicate);
     } else {
       return false;
     }

querydsl-libraries/querydsl-core/src/main/java/com/querydsl/core/DefaultQueryMetadata.java

@@ -158,7 +158,7 @@ private void addLastJoin() {
   public void addJoin(JoinType joinType, Expression<?> expr) {
     addLastJoin();
     if (!exprInJoins.contains(expr)) {
-      if (expr instanceof Path && ((Path<?>) expr).getMetadata().isRoot()) {
+      if (expr instanceof Path<?> path && path.getMetadata().isRoot()) {
         exprInJoins.add(expr);
       } else {
         validate(expr);
@@ -378,8 +378,7 @@ public void setValidatingVisitor(ValidatingVisitor visitor) {
 
   @Override
   public boolean equals(Object o) {
-    if (o instanceof QueryMetadata) {
-      var q = (QueryMetadata) o;
+    if (o instanceof QueryMetadata q) {
       return q.getFlags().equals(flags)
           && q.getGroupBy().equals(groupBy)
           && Objects.equals(q.getHaving(), having)

querydsl-libraries/querydsl-core/src/main/java/com/querydsl/core/JoinExpression.java

@@ -107,8 +107,7 @@ public int hashCode() {
   public boolean equals(Object o) {
     if (o == this) {
       return true;
-    } else if (o instanceof JoinExpression) {
-      var j = (JoinExpression) o;
+    } else if (o instanceof JoinExpression j) {
       return Objects.equals(condition, j.condition)
           && Objects.equals(target, j.target)
           && Objects.equals(type, j.type);

querydsl-libraries/querydsl-core/src/main/java/com/querydsl/core/JoinFlag.java

@@ -106,8 +106,8 @@ public int hashCode() {
   public boolean equals(Object obj) {
     if (obj == this) {
       return true;
-    } else if (obj instanceof JoinFlag) {
-      return ((JoinFlag) obj).flag.equals(flag);
+    } else if (obj instanceof JoinFlag joinFlag) {
+      return joinFlag.flag.equals(flag);
     } else {
       return false;
     }

querydsl-libraries/querydsl-core/src/main/java/com/querydsl/core/QueryFlag.java

@@ -103,8 +103,7 @@ public int hashCode() {
   public boolean equals(Object obj) {
     if (obj == this) {
       return true;
-    } else if (obj instanceof QueryFlag) {
-      var other = (QueryFlag) obj;
+    } else if (obj instanceof QueryFlag other) {
       return other.position.equals(position) && other.flag.equals(flag);
     } else {
       return false;

querydsl-libraries/querydsl-core/src/main/java/com/querydsl/core/QueryModifiers.java

@@ -120,8 +120,7 @@ public <T> List<T> subList(List<T> list) {
   public boolean equals(Object o) {
     if (o == this) {
       return true;
-    } else if (o instanceof QueryModifiers) {
-      var qm = (QueryModifiers) o;
+    } else if (o instanceof QueryModifiers qm) {
       return Objects.equals(qm.getLimit(), limit) && Objects.equals(qm.getOffset(), offset);
     } else {
       return false;

querydsl-libraries/querydsl-core/src/main/java/com/querydsl/core/alias/Alias.java

@@ -162,8 +162,8 @@ public final class Alias {
     final Object current = aliasFactory.getCurrentAndReset();
     if (arg instanceof CollectionPath) {
       return (CollectionPath<D, SimpleExpression<D>>) arg; // NOSONAR
-    } else if (arg instanceof ManagedObject) {
-      return (CollectionPath<D, SimpleExpression<D>>) ((ManagedObject) arg).__mappedPath();
+    } else if (arg instanceof ManagedObject object) {
+      return (CollectionPath<D, SimpleExpression<D>>) object.__mappedPath();
     } else {
       return (CollectionPath<D, SimpleExpression<D>>) current;
     }
@@ -242,8 +242,8 @@ public final class Alias {
     final Object current = aliasFactory.getCurrentAndReset();
     if (arg instanceof ListPath) {
       return (ListPath<D, SimpleExpression<D>>) arg; // NOSONAR
-    } else if (arg instanceof ManagedObject) {
-      return (ListPath<D, SimpleExpression<D>>) ((ManagedObject) arg).__mappedPath();
+    } else if (arg instanceof ManagedObject object) {
+      return (ListPath<D, SimpleExpression<D>>) object.__mappedPath();
     } else {
       return (ListPath<D, SimpleExpression<D>>) current;
     }
@@ -272,8 +272,8 @@ public final class Alias {
     final Object current = aliasFactory.getCurrentAndReset();
     if (arg instanceof MapPath) {
       return (MapPath<K, V, SimpleExpression<V>>) arg; // NOSONAR
-    } else if (arg instanceof ManagedObject) {
-      return (MapPath<K, V, SimpleExpression<V>>) ((ManagedObject) arg).__mappedPath();
+    } else if (arg instanceof ManagedObject object) {
+      return (MapPath<K, V, SimpleExpression<V>>) object.__mappedPath();
     } else {
       return (MapPath<K, V, SimpleExpression<V>>) current;
     }
@@ -291,8 +291,8 @@ public final class Alias {
     final Object current = aliasFactory.getCurrentAndReset();
     if (arg instanceof SetPath) {
       return (SetPath<D, SimpleExpression<D>>) arg; // NOSONAR
-    } else if (arg instanceof ManagedObject) {
-      return (SetPath<D, SimpleExpression<D>>) ((ManagedObject) arg).__mappedPath();
+    } else if (arg instanceof ManagedObject object) {
+      return (SetPath<D, SimpleExpression<D>>) object.__mappedPath();
     } else {
       return (SetPath<D, SimpleExpression<D>>) current;
     }
@@ -351,8 +351,8 @@ public final class Alias {
     final Object current = aliasFactory.getCurrentAndReset();
     if (arg instanceof EntityPath<?>) {
       return (EntityPathBase<D>) arg; // NOSONAR
-    } else if (arg instanceof ManagedObject) {
-      return (EntityPathBase<D>) ((ManagedObject) arg).__mappedPath();
+    } else if (arg instanceof ManagedObject object) {
+      return (EntityPathBase<D>) object.__mappedPath();
     } else {
       return (EntityPathBase<D>) current;
     }
@@ -364,8 +364,8 @@ private static <D, P extends Path<D>> P getPath(D arg) {
     final Object current = aliasFactory.getCurrentAndReset();
     if (arg instanceof Path<?>) {
       return (P) arg;
-    } else if (arg instanceof ManagedObject) {
-      return (P) ((ManagedObject) arg).__mappedPath();
+    } else if (arg instanceof ManagedObject object) {
+      return (P) object.__mappedPath();
     } else {
       return (P) current;
     }
@@ -415,8 +415,8 @@ public static <A> A alias(Class<A> cl, String var) {
   @SuppressWarnings("unchecked")
   public static <D> Expression<D> getAny(D arg) {
     Object current = aliasFactory.getCurrentAndReset();
-    if (arg instanceof ManagedObject) {
-      return (Expression<D>) ((ManagedObject) arg).__mappedPath();
+    if (arg instanceof ManagedObject object) {
+      return (Expression<D>) object.__mappedPath();
     } else if (current != null) {
       return (Expression<D>) current;
     } else {

querydsl-libraries/querydsl-core/src/main/java/com/querydsl/core/group/AbstractGroupByTransformer.java

@@ -74,13 +74,12 @@ protected AbstractGroupByTransformer(Expression<K> key, Expression<?>... express
     projection.add(key);
 
     for (Expression<?> expr : expressions) {
-      if (expr instanceof GroupExpression<?, ?>) {
-        GroupExpression<?, ?> groupExpr = (GroupExpression<?, ?>) expr;
+      if (expr instanceof GroupExpression<?, ?> groupExpr) {
         groupExpressions.add(groupExpr);
         Expression<?> colExpression = groupExpr.getExpression();
-        if (colExpression instanceof Operation
-            && ((Operation) colExpression).getOperator() == Ops.ALIAS) {
-          projection.add(((Operation) colExpression).getArg(0));
+        if (colExpression instanceof Operation<?> operation
+            && operation.getOperator() == Ops.ALIAS) {
+          projection.add(operation.getArg(0));
         } else {
           projection.add(colExpression);
         }
@@ -100,8 +99,8 @@ protected static FactoryExpression<Tuple> withoutGroupExpressions(
       final FactoryExpression<Tuple> expr) {
     List<Expression<?>> args = new ArrayList<>(expr.getArgs().size());
     for (Expression<?> arg : expr.getArgs()) {
-      if (arg instanceof GroupExpression) {
-        args.add(((GroupExpression) arg).getExpression());
+      if (arg instanceof GroupExpression<?, ?> expression) {
+        args.add(expression.getExpression());
       } else {
         args.add(arg);
       }