GH-934: Update Default Client to handle Compression correctly #1349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdavisk6
force-pushed
the
gh-934-gzip-response
branch
from
0a048b1 to
d7fe851
Compare
kdavisk6
changed the title
This change updates the Input Stream handling when using the Default client implementation to detect when a response is `gzipped` and wrap it in a `GZipInputStream`. This addresses any issues related to compression when using the default client.
Fixes: OpenFeign#1208 Forgot to add Defate support and removed the implicit parsing of the body during toString. This was also brought up in OpenFeign#1208 and it came up during testing of this change. Users should be using our `asReader` and other methods to access the response body.
kdavisk6
force-pushed
the
gh-934-gzip-response
branch
from
c6cf351 to
5efc1c1
Compare
velo
pushed a commit
that referenced
this pull request
Oct 7, 2024
Fixes: #934, #1208 This change updates the Input Stream handling when using the Default client implementation to detect when a response is `gzipped` and wrap it in a `GZipInputStream`. This addresses any issues related to compression when using the default client. In addition, removed the implicit parsing of the body during toString. This was also brought up in #1208 and it came up during testing of this change. Users should be using our `asReader` and other methods to access the response body. * Adding Deflate support * Added Deflate Support and removed implicit response body reading * Refactored Gzip and Deflate Conditions * Corrected formatting and line-endings
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
Fixes: #934, #1208 This change updates the Input Stream handling when using the Default client implementation to detect when a response is `gzipped` and wrap it in a `GZipInputStream`. This addresses any issues related to compression when using the default client. In addition, removed the implicit parsing of the body during toString. This was also brought up in #1208 and it came up during testing of this change. Users should be using our `asReader` and other methods to access the response body. * Adding Deflate support * Added Deflate Support and removed implicit response body reading * Refactored Gzip and Deflate Conditions * Corrected formatting and line-endings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #934, #1208
This change updates the Input Stream handling when using the Default client implementation to detect when a response is
gzippedand wrap it in aGZipInputStreamand the same fordeflateandInflaterInputStreamrespectively.This addresses any issues related to compression when using the default client.
Additional Changes:
Removed the implicit parsing of the body during
toString. This was also brought up in #1208 and it came upduring testing of this change. Users should be using our
asReaderand other methods to access the response body.