Added Deflate Support and removed implict response body reading

Fixes: #1208

Forgot to add Defate support and removed the implicit parsing of the
body during toString.  This was also brought up in #1208 and it came up
during testing of this change.  Users should be using our `asReader`
and other methods to access the response body.

Author: kdavisk6

core/src/test/java/feign/AsyncFeignTest.java

@@ -91,18 +91,6 @@ public void postTemplateParamsResolve() throws Exception {
         "{\"customer_name\": \"netflix\", \"user_name\": \"denominator\", \"password\": \"password\"}");
   }
 
-  @Test
-  public void responseCoercesToStringBody() throws Throwable {
-    server.enqueue(new MockResponse().setBody("foo"));
-
-    TestInterfaceAsync api =
-        new TestInterfaceAsyncBuilder().target("http://localhost:" + server.getPort());
-
-    Response response = unwrap(api.response());
-    assertTrue(response.body().isRepeatable());
-    assertEquals("foo", response.body().toString());
-  }
-
   @Test
   public void postFormParams() throws Exception {
     server.enqueue(new MockResponse().setBody("foo"));

core/src/test/java/feign/FeignTest.java

@@ -92,17 +92,6 @@ public void postTemplateParamsResolve() throws Exception {
             "{\"customer_name\": \"netflix\", \"user_name\": \"denominator\", \"password\": \"password\"}");
   }
 
-  @Test
-  public void responseCoercesToStringBody() {
-    server.enqueue(new MockResponse().setBody("foo"));
-
-    TestInterface api = new TestInterfaceBuilder().target("http://localhost:" + server.getPort());
-
-    Response response = api.response();
-    assertTrue(response.body().isRepeatable());
-    assertEquals("foo", response.body().toString());
-  }
-
   @Test
   public void postFormParams() throws Exception {
     server.enqueue(new MockResponse().setBody("foo"));

core/src/test/java/feign/FeignUnderAsyncTest.java

@@ -89,17 +89,6 @@ public void postTemplateParamsResolve() throws Exception {
             "{\"customer_name\": \"netflix\", \"user_name\": \"denominator\", \"password\": \"password\"}");
   }
 
-  @Test
-  public void responseCoercesToStringBody() {
-    server.enqueue(new MockResponse().setBody("foo"));
-
-    TestInterface api = new TestInterfaceBuilder().target("http://localhost:" + server.getPort());
-
-    Response response = api.response();
-    assertTrue(response.body().isRepeatable());
-    assertEquals("foo", response.body().toString());
-  }
-
   @Test
   public void postFormParams() throws Exception {
     server.enqueue(new MockResponse().setBody("foo"));

core/src/test/java/feign/ResponseTest.java

@@ -14,6 +14,7 @@
 package feign;
 
 import feign.Request.HttpMethod;
+import java.nio.charset.StandardCharsets;
 import org.assertj.core.util.Lists;
 import org.junit.Test;
 import java.util.Arrays;
@@ -38,7 +39,7 @@ public void reasonPhraseIsOptional() {
         .build();
 
     assertThat(response.reason()).isNull();
-    assertThat(response.toString()).isEqualTo("HTTP/1.1 200\n\n");
+    assertThat(response.toString()).startsWith("HTTP/1.1 200");
   }
 
   @Test

hc5/src/test/java/feign/hc5/AsyncApacheHttp5ClientTest.java

@@ -76,18 +76,6 @@ public void postTemplateParamsResolve() throws Exception {
         "{\"customer_name\": \"netflix\", \"user_name\": \"denominator\", \"password\": \"password\"}");
   }
 
-  @Test
-  public void responseCoercesToStringBody() throws Throwable {
-    server.enqueue(new MockResponse().setBody("foo"));
-
-    final TestInterfaceAsync api =
-        new TestInterfaceAsyncBuilder().target("http://localhost:" + server.getPort());
-
-    final Response response = unwrap(api.response());
-    assertTrue(response.body().isRepeatable());
-    assertEquals("foo", response.body().toString());
-  }
-
   @Test
   public void postFormParams() throws Exception {
     server.enqueue(new MockResponse().setBody("foo"));

okhttp/src/test/java/feign/okhttp/OkHttpClientTest.java

@@ -22,6 +22,7 @@
 import feign.assertj.MockWebServerAssertions;
 import feign.client.AbstractClientTest;
 import feign.Feign;
+import java.nio.charset.StandardCharsets;
 import java.util.Collections;
 import java.util.concurrent.TimeUnit;
 import okhttp3.mockwebserver.MockResponse;
@@ -97,7 +98,8 @@ public void testFollowRedirect() throws Exception {
     Response response = api.get();
     // Response length should not be null
     assertEquals(200, response.status());
-    assertEquals(expectedBody, response.body().toString());
+    String payload = Util.toString(response.body().asReader(StandardCharsets.UTF_8));
+    assertEquals(expectedBody, payload);
 
   }