Skip to content

Commit ad8aa72

Browse files
iwek7miwanczukvelo
authored
Adds convenient overloaded constructor for Request.Options (#2093)
Co-authored-by: miwanczuk <michal.iwanczuk@empik.com> Co-authored-by: Marvin Froeder <velo@users.noreply.github.com>
1 parent a488c41 commit ad8aa72

File tree

1 file changed

+17
-0
lines changed

1 file changed

+17
-0
lines changed

core/src/main/java/feign/Request.java

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import java.io.Serializable;
2020
import java.net.HttpURLConnection;
2121
import java.nio.charset.Charset;
22+
import java.time.Duration;
2223
import java.util.Arrays;
2324
import java.util.Collection;
2425
import java.util.Collections;
@@ -373,6 +374,22 @@ public Options(int connectTimeoutMillis, int readTimeoutMillis) {
373374
this(connectTimeoutMillis, readTimeoutMillis, true);
374375
}
375376

377+
/**
378+
* Creates a new Options Instance.
379+
*
380+
* @param connectTimeout value.
381+
* @param readTimeout value.
382+
* @param followRedirects if the request should follow 3xx redirections.
383+
*/
384+
public Options(Duration connectTimeout, Duration readTimeout, boolean followRedirects) {
385+
this(
386+
connectTimeout.toMillis(),
387+
TimeUnit.MILLISECONDS,
388+
readTimeout.toMillis(),
389+
TimeUnit.MILLISECONDS,
390+
followRedirects);
391+
}
392+
376393
/**
377394
* Creates the new Options instance using the following defaults:
378395
*

0 commit comments

Comments
 (0)