Prevented tests of feign-form from writing logs (#2633)

Test were creating logs files on the root of project, making all subsequent
builds fail.

Author: hosuaby

form/src/test/java/feign/form/BasicClientTest.java

@@ -31,19 +31,26 @@
 import java.util.Arrays;
 import java.util.Map;
 import lombok.val;
+import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.io.TempDir;
 import org.springframework.boot.test.context.SpringBootTest;
 
 @SpringBootTest(webEnvironment = DEFINED_PORT, classes = Server.class)
 class BasicClientTest {
 
-  private static final TestClient API;
+  private static TestClient API;
+
+  @TempDir static Path logDir;
+
+  @BeforeAll
+  static void configureClient() {
+    val logFile = logDir.resolve("log.txt").toString();
 
-  static {
     API =
         Feign.builder()
             .encoder(new FormEncoder(new JacksonEncoder()))
-            .logger(new JavaLogger(BasicClientTest.class).appendToFile("log.txt"))
+            .logger(new JavaLogger(BasicClientTest.class).appendToFile(logFile))
             .logLevel(FULL)
             .target(TestClient.class, "http://localhost:8080");
   }

form/src/test/java/feign/form/ByteArrayClientTest.java

@@ -26,22 +26,29 @@
 import feign.RequestLine;
 import feign.Response;
 import feign.jackson.JacksonEncoder;
+import java.nio.file.Path;
 import lombok.val;
+import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.io.TempDir;
 import org.springframework.boot.test.context.SpringBootTest;
 
 @SpringBootTest(webEnvironment = DEFINED_PORT, classes = Server.class)
 class ByteArrayClientTest {
 
-  private static final CustomClient API;
+  private static CustomClient API;
 
-  static {
+  @TempDir static Path logDir;
+
+  @BeforeAll
+  static void configureClient() {
     val encoder = new FormEncoder(new JacksonEncoder());
+    val logFile = logDir.resolve("log-byte.txt").toString();
 
     API =
         Feign.builder()
             .encoder(encoder)
-            .logger(new JavaLogger(ByteArrayClientTest.class).appendToFile("log-byte.txt"))
+            .logger(new JavaLogger(ByteArrayClientTest.class).appendToFile(logFile))
             .logLevel(FULL)
             .target(CustomClient.class, "http://localhost:8080");
   }

form/src/test/java/feign/form/CustomClientTest.java

@@ -29,24 +29,32 @@
 import feign.form.multipart.ByteArrayWriter;
 import feign.form.multipart.Output;
 import feign.jackson.JacksonEncoder;
+import java.nio.file.Path;
 import lombok.val;
+import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.io.TempDir;
 import org.springframework.boot.test.context.SpringBootTest;
 
 @SpringBootTest(webEnvironment = DEFINED_PORT, classes = Server.class)
 class CustomClientTest {
 
-  private static final CustomClient API;
+  private static CustomClient API;
 
-  static {
+  @TempDir static Path logDir;
+
+  @BeforeAll
+  static void configureClient() {
     val encoder = new FormEncoder(new JacksonEncoder());
     val processor = (MultipartFormContentProcessor) encoder.getContentProcessor(MULTIPART);
     processor.addFirstWriter(new CustomByteArrayWriter());
 
+    val logFile = logDir.resolve("log.txt").toString();
+
     API =
         Feign.builder()
             .encoder(encoder)
-            .logger(new JavaLogger(CustomClientTest.class).appendToFile("log.txt"))
+            .logger(new JavaLogger(CustomClientTest.class).appendToFile(logFile))
             .logLevel(FULL)
             .target(CustomClient.class, "http://localhost:8080");
   }

form/src/test/java/feign/form/FormPropertyTest.java

@@ -24,20 +24,28 @@
 import feign.Logger.JavaLogger;
 import feign.RequestLine;
 import feign.jackson.JacksonEncoder;
+import java.nio.file.Path;
 import lombok.val;
+import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.io.TempDir;
 import org.springframework.boot.test.context.SpringBootTest;
 
 @SpringBootTest(webEnvironment = DEFINED_PORT, classes = Server.class)
 class FormPropertyTest {
 
-  private static final FormClient API;
+  private static FormClient API;
+
+  @TempDir static Path logDir;
+
+  @BeforeAll
+  static void configureClient() {
+    val logFile = logDir.resolve("log.txt").toString();
 
-  static {
     API =
         Feign.builder()
             .encoder(new FormEncoder(new JacksonEncoder()))
-            .logger(new JavaLogger(FormPropertyTest.class).appendToFile("log.txt"))
+            .logger(new JavaLogger(FormPropertyTest.class).appendToFile(logFile))
             .logLevel(FULL)
             .target(FormClient.class, "http://localhost:8080");
   }

form/src/test/java/feign/form/WildCardMapTest.java

@@ -24,23 +24,30 @@
 import feign.Logger.JavaLogger;
 import feign.RequestLine;
 import feign.Response;
+import java.nio.file.Path;
 import java.util.HashMap;
 import java.util.Map;
+import lombok.val;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.io.TempDir;
 import org.springframework.boot.test.context.SpringBootTest;
 
 @SpringBootTest(webEnvironment = DEFINED_PORT, classes = Server.class)
 class WildCardMapTest {
 
   private static FormUrlEncodedApi api;
 
+  @TempDir static Path logDir;
+
   @BeforeAll
   static void configureClient() {
+    val logFile = logDir.resolve("log.txt").toString();
+
     api =
         Feign.builder()
             .encoder(new FormEncoder())
-            .logger(new JavaLogger(WildCardMapTest.class).appendToFile("log.txt"))
+            .logger(new JavaLogger(WildCardMapTest.class).appendToFile(logFile))
             .logLevel(FULL)
             .target(FormUrlEncodedApi.class, "http://localhost:8080");
   }