Add. two new constructors to RetryableException:

- A constructor without retryAfter and without cause
- A constructor without retryAfter but with cause

Standardized JavaDoc across all RetryableException constructors

These new constructors remove overload ambiguity when retryAfter is not needed.

Add. a unit test to verify the new constructors.
- canCreateRetryableExceptionWithoutRetryAfter
- canCreateRetryableExceptionWithoutRetryAfterAndWithCause

Fixes #2458

Author: rojae

core/src/main/java/feign/RetryableException.java

@@ -33,30 +33,26 @@ public class RetryableException extends FeignException {
 
   /**
    * Represents a non-retryable exception when Retry-After information is explicitly not provided.
-   * <p>
-   * Use this constructor when the server response does not include a Retry-After header
-   * or when retries are not expected.
+   *
+   * <p>Use this constructor when the server response does not include a Retry-After header or when
+   * retries are not expected.
    *
    * @param status the HTTP status code
    * @param message the exception message
    * @param httpMethod the HTTP method (GET, POST, etc.)
    * @param request the original HTTP request
    */
-  public RetryableException(
-      int status,
-      String message,
-      HttpMethod httpMethod,
-      Request request) {
+  public RetryableException(int status, String message, HttpMethod httpMethod, Request request) {
     super(status, message, request);
     this.httpMethod = httpMethod;
     this.retryAfter = null;
   }
 
   /**
    * Represents a non-retryable exception when Retry-After information is explicitly not provided.
-   * <p>
-   * Use this constructor when the server response does not include a Retry-After header
-   * or when retries are not expected.
+   *
+   * <p>Use this constructor when the server response does not include a Retry-After header or when
+   * retries are not expected.
    *
    * @param status the HTTP status code
    * @param message the exception message
@@ -65,32 +61,28 @@ public RetryableException(
    * @param request the original HTTP request
    */
   public RetryableException(
-      int status,
-      String message,
-      HttpMethod httpMethod,
-      Throwable cause,
-      Request request) {
+      int status, String message, HttpMethod httpMethod, Throwable cause, Request request) {
     super(status, message, request, cause);
     this.httpMethod = httpMethod;
     this.retryAfter = null;
   }
 
   /**
    * Represents a retryable exception when Retry-After information is available.
-   * <p>
-   * Use this constructor when the server response includes a Retry-After header
-   * specifying the delay in milliseconds before retrying.
-   * <p>
-   * If {@code retryAfter} is {@code null}, prefer using
-   * {@link #RetryableException(int, String, HttpMethod, Throwable, Request)} instead.
+   *
+   * <p>Use this constructor when the server response includes a Retry-After header specifying the
+   * delay in milliseconds before retrying.
+   *
+   * <p>If {@code retryAfter} is {@code null}, prefer using {@link #RetryableException(int, String,
+   * HttpMethod, Throwable, Request)} instead.
    *
    * @param status the HTTP status code
    * @param message the exception message
    * @param httpMethod the HTTP method (GET, POST, etc.)
    * @param cause the underlying cause of the exception
-   * @param retryAfter the retry delay in milliseconds
-   *                   retryAfter usually corresponds to the {@link feign.Util#RETRY_AFTER} header. If you
-   *                   don't want to retry, use {@link #RetryableException(int, String, HttpMethod, Throwable, Request)}.
+   * @param retryAfter the retry delay in milliseconds retryAfter usually corresponds to the {@link
+   *     feign.Util#RETRY_AFTER} header. If you don't want to retry, use {@link
+   *     #RetryableException(int, String, HttpMethod, Throwable, Request)}.
    * @param request the original HTTP request
    */
   public RetryableException(
@@ -107,8 +99,8 @@ public RetryableException(
 
   /**
    * @deprecated Use {@link #RetryableException(int, String, HttpMethod, Throwable, Long, Request)}
-   * instead. This constructor uses {@link Date} for retryAfter, which has been replaced by {@link Long}.
-   *
+   *     instead. This constructor uses {@link Date} for retryAfter, which has been replaced by
+   *     {@link Long}.
    * @param status the HTTP status code
    * @param message the exception message
    * @param httpMethod the HTTP method (GET, POST, etc.)
@@ -131,15 +123,15 @@ public RetryableException(
 
   /**
    * Represents a retryable exception when Retry-After information is available.
-   * <p>
-   * Use this constructor when the server response includes a Retry-After header.
+   *
+   * <p>Use this constructor when the server response includes a Retry-After header.
    *
    * @param status the HTTP status code
    * @param message the exception message
    * @param httpMethod the HTTP method (GET, POST, etc.)
-   * @param retryAfter the retry delay in milliseconds
-   *                   retryAfter usually corresponds to the {@link feign.Util#RETRY_AFTER} header. If you
-   *                   don't want to retry, use {@link #RetryableException(int, String, HttpMethod, Request)}
+   * @param retryAfter the retry delay in milliseconds retryAfter usually corresponds to the {@link
+   *     feign.Util#RETRY_AFTER} header. If you don't want to retry, use {@link
+   *     #RetryableException(int, String, HttpMethod, Request)}
    * @param request the original HTTP request
    */
   public RetryableException(
@@ -150,9 +142,8 @@ public RetryableException(
   }
 
   /**
-   * @deprecated Use {@link #RetryableException(int, String, HttpMethod, Long, Request)}
-   * instead. This constructor uses {@link Date} for retryAfter, which has been replaced by {@link Long}.
-   *
+   * @deprecated Use {@link #RetryableException(int, String, HttpMethod, Long, Request)} instead.
+   *     This constructor uses {@link Date} for retryAfter, which has been replaced by {@link Long}.
    * @param status the HTTP status code
    * @param message the exception message
    * @param httpMethod the HTTP method (GET, POST, etc.)
@@ -169,14 +160,14 @@ public RetryableException(
 
   /**
    * Represents a retryable exception with response body and headers.
-   * <p>
-   * Use this constructor when handling HTTP responses that include Retry-After information.
+   *
+   * <p>Use this constructor when handling HTTP responses that include Retry-After information.
    *
    * @param status the HTTP status code
    * @param message the exception message
    * @param httpMethod the HTTP method (GET, POST, etc.)
-   * @param retryAfter the retry delay in milliseconds
-   *                   retryAfter usually corresponds to the {@link feign.Util#RETRY_AFTER} header.
+   * @param retryAfter the retry delay in milliseconds retryAfter usually corresponds to the {@link
+   *     feign.Util#RETRY_AFTER} header.
    * @param request the original HTTP request
    * @param responseBody the HTTP response body
    * @param responseHeaders the HTTP response headers
@@ -195,9 +186,9 @@ public RetryableException(
   }
 
   /**
-   * @deprecated Use {@link #RetryableException(int, String, HttpMethod, Long, Request, byte[], Map)}
-   * instead. This constructor uses {@link Date} for retryAfter, which has been replaced by {@link Long}.
-   *
+   * @deprecated Use {@link #RetryableException(int, String, HttpMethod, Long, Request, byte[],
+   *     Map)} instead. This constructor uses {@link Date} for retryAfter, which has been replaced
+   *     by {@link Long}.
    * @param status the HTTP status code
    * @param message the exception message
    * @param httpMethod the HTTP method (GET, POST, etc.)

core/src/test/java/feign/RetryerTest.java

@@ -99,7 +99,8 @@ void defaultRetryerFailsOnInterruptedException() {
 
   @Test
   void canCreateRetryableExceptionWithoutRetryAfter() {
-    RetryableException exception = new RetryableException(500, "Internal Server Error", Request.HttpMethod.GET, REQUEST);
+    RetryableException exception =
+        new RetryableException(500, "Internal Server Error", Request.HttpMethod.GET, REQUEST);
 
     assertThat(exception.status()).isEqualTo(500);
     assertThat(exception.getMessage()).contains("Internal Server Error");
@@ -112,7 +113,8 @@ void canCreateRetryableExceptionWithoutRetryAfterAndWithCause() {
     Throwable cause = new IllegalArgumentException("Illegal argument exception");
 
     try {
-      throw new RetryableException(500, "Internal Server Error", Request.HttpMethod.GET, cause, REQUEST);
+      throw new RetryableException(
+          500, "Internal Server Error", Request.HttpMethod.GET, cause, REQUEST);
     } catch (RetryableException exception) {
       assertThat(exception.status()).isEqualTo(500);
       assertThat(exception.getMessage()).contains("Internal Server Error");