Add aerodyn driver test for MHK turbine with IfW based inflow #3173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new AeroDyn driver regression test for an MHK RM1 fixed turbine case using InflowWind-based inflow, to ensure inflow accelerations remain correctly computed when CompInflow=1.
Changes:
- Updated the
reg_testssubproject pointer to a newer commit containing the new regression test assets. - Registered a new CTest entry
ad_MHK_RM1_Fixed_IfWunder the AeroDyn/BEM/MHK regression suite.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| reg_tests/r-test | Bumps the reg_tests subproject commit to pick up the new test case content. |
| reg_tests/CTestList.cmake | Adds the new ad_MHK_RM1_Fixed_IfW regression test to the CTest list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
andrew-platt
approved these changes
Jan 27, 2026
Collaborator
andrew-platt
left a comment
andrew-platt
left a comment
There was a problem hiding this comment.
Thanks for putting that together!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready to merge
Feature or improvement description
This PR adds a test case for the aerodyn driver for an MHK turbine with InflowWind based inflow to demonstrate that the functionality works.
Additional supporting information
This was in response to a report that the aerodyn driver wasn't calculating inflow accelerations when CompInflow=1. However, this test shows that InflowWind was working properly. Adding the test so that this continues to work in the future.