Skip to content

Conversation

@andrew-platt
Copy link
Collaborator

Ready to merge

Feature or improvement description
A few pieces were missing in the RunRegistry.bat after merging dev in.

  • fix missing include dirs in RunRegistry.bat
  • update dependencies on IfW MD in solution
  • remove the compiler specification form the vfproj files (old ifx installs wouldn't work)

Related issue, if one exists
Reported internally

Impacted areas of the software
Compilation with VS on Windows, and on GH actions.

Additional supporting information
SeaState was coupled to InflowWind, but not updated in the VS project. This resulted in missing dependencies while building MoorDyn.

Test results, if applicable
No test results affected.

- fix missing include dirs in RunRegistry.bat
- update dependencies on IfW MD in solution
- remove the compiler specification form the vfproj files (old ifx
  installs wouldn't work)
- InflowWind_driver - remove `registry` dependency (failed at linking,
  no other drivers have this)
- add error handling in batch file to run the devenv builds with VS
- drop the `_x64` part of names in test part of `deploy` script
@andrew-platt
Copy link
Collaborator Author

andrew-platt commented Aug 18, 2025

To do:

  • update InflowWind driver dependency on registry.lib
  • Update testing to point to correct location OpenFAST executable (currently build/bin/openfast_x64.exe, but should be build/bin/openfast.exe

Copy link
Collaborator

@deslaughter deslaughter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working in Visual Studio 2022 and Intel oneAPI IFX 2025.2.1

@andrew-platt
Copy link
Collaborator Author

Some issues remaining with the deploy script that I cannot figure out:

@andrew-platt andrew-platt merged commit f7fe65e into OpenFAST:dev-tc Aug 22, 2025
35 of 36 checks passed
@andrew-platt andrew-platt deleted the b/dev-tc_VSbuild branch September 3, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants