Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically add new tables to existing databases #516

Open
FlorianK13 opened this issue Apr 25, 2024 · 4 comments
Open

Dynamically add new tables to existing databases #516

FlorianK13 opened this issue Apr 25, 2024 · 4 comments
Labels
🐛 bug Something isn't working

Comments

@FlorianK13
Copy link
Member

FlorianK13 commented Apr 25, 2024

If new tables are introduced by BNetzA, the current code cannot simply add them to an existing database. For example, when running db.download() and there is already a database initialized, a new table will cause an error. This should be changed, ie. new tables should be added automatically.

They should take the name from orm.py if the new table is already part of a new open-mastr release. Or they should just use the german name otherwise.

@FlorianK13 FlorianK13 added the 🐛 bug Something isn't working label Apr 25, 2024
@FlorianK13 FlorianK13 changed the title Add new tables to existing databases Dynamically add new tables to existing databases Apr 25, 2024
@nesnoj
Copy link
Collaborator

nesnoj commented Jul 4, 2024

An automatic creation be great, but the value replacement (e.g. 4=biomass) should be added too.

@FlorianK13
Copy link
Member Author

If only this was already implemented, we would not need to handle #572 under time pressure 🙄

@FlorianK13
Copy link
Member Author

With 0.14.5 we now have at least the case that tables that are new do not result in a crash anymore. However they are still not automatically added.

@nesnoj
Copy link
Collaborator

nesnoj commented Oct 15, 2024

Yes, let's talk about this in our JF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants