feat: rename license_name to license_title

Author: tillywoodfield

migrations/versions/8182d8c386f7_rename_column_license_name_to_license_.py

@@ -0,0 +1,34 @@
+"""rename column license name to license title
+
+Revision ID: 8182d8c386f7
+Revises: 3499656b84e7
+Create Date: 2025-02-25 15:40:01.727396
+
+"""
+
+from typing import Sequence, Union
+
+from alembic import op
+
+
+# revision identifiers, used by Alembic.
+revision: str = "8182d8c386f7"
+down_revision: Union[str, None] = "3499656b84e7"
+branch_labels: Union[str, Sequence[str], None] = None
+depends_on: Union[str, Sequence[str], None] = None
+
+
+def upgrade() -> None:
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.alter_column(
+        "dataset", "license_name", nullable=True, new_column_name="license_title"
+    )
+    # ### end Alembic commands ###
+
+
+def downgrade() -> None:
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.alter_column(
+        "dataset", "license_title", nullable=True, new_column_name="license_name"
+    )
+    # ### end Alembic commands ###

oc4ids_datastore_pipeline/database.py

@@ -29,7 +29,7 @@ class Dataset(Base):
     source_url: Mapped[str] = mapped_column(String)
     publisher_name: Mapped[str] = mapped_column(String)
     license_url: Mapped[Optional[str]] = mapped_column(String, nullable=True)
-    license_name: Mapped[Optional[str]] = mapped_column(String, nullable=True)
+    license_title: Mapped[Optional[str]] = mapped_column(String, nullable=True)
     json_url: Mapped[Optional[str]] = mapped_column(String, nullable=True)
     csv_url: Mapped[Optional[str]] = mapped_column(String, nullable=True)
     xlsx_url: Mapped[Optional[str]] = mapped_column(String, nullable=True)

oc4ids_datastore_pipeline/pipeline.py

@@ -18,7 +18,7 @@
 from oc4ids_datastore_pipeline.notifications import send_notification
 from oc4ids_datastore_pipeline.registry import (
     fetch_registered_datasets,
-    get_license_name_from_url,
+    get_license_title_from_url,
 )
 from oc4ids_datastore_pipeline.storage import delete_files_for_dataset, upload_files
 
@@ -108,13 +108,13 @@ def save_dataset_metadata(
     try:
         publisher_name = json_data.get("publisher", {}).get("name", "")
         license_url = json_data.get("license", None)
-        license_name = get_license_name_from_url(license_url) if license_url else None
+        license_title = get_license_title_from_url(license_url) if license_url else None
         dataset = Dataset(
             dataset_id=dataset_id,
             source_url=source_url,
             publisher_name=publisher_name,
             license_url=license_url,
-            license_name=license_name,
+            license_title=license_title,
             json_url=json_url,
             csv_url=csv_url,
             xlsx_url=xlsx_url,

oc4ids_datastore_pipeline/registry.py

@@ -50,7 +50,7 @@ def fetch_license_mappings() -> dict[str, str]:
         return {}
 
 
-def get_license_name_from_url(
+def get_license_title_from_url(
     url: str, force_refresh: Optional[bool] = False
 ) -> Optional[str]:
     global _license_mappings

tests/test_registry.py

@@ -6,7 +6,7 @@
 from oc4ids_datastore_pipeline.registry import (
     fetch_license_mappings,
     fetch_registered_datasets,
-    get_license_name_from_url,
+    get_license_title_from_url,
 )
 
 
@@ -116,7 +116,7 @@ def test_fetch_license_mappings_catches_exception(
     assert result == {}
 
 
-def test_get_license_name_from_url(mocker: MockerFixture) -> None:
+def test_get_license_title_from_url(mocker: MockerFixture) -> None:
     patch_license_mappings = mocker.patch(
         "oc4ids_datastore_pipeline.registry.fetch_license_mappings"
     )
@@ -125,23 +125,23 @@ def test_get_license_name_from_url(mocker: MockerFixture) -> None:
         "https://license_2.com/license": "License 2",
     }
 
-    license_name = get_license_name_from_url(
+    license_title = get_license_title_from_url(
         "https://license_2.com/license", force_refresh=True
     )
 
-    assert license_name == "License 2"
+    assert license_title == "License 2"
 
 
-def test_get_license_name_from_url_not_in_mapping(mocker: MockerFixture) -> None:
+def test_get_license_title_from_url_not_in_mapping(mocker: MockerFixture) -> None:
     patch_license_mappings = mocker.patch(
         "oc4ids_datastore_pipeline.registry.fetch_license_mappings"
     )
     patch_license_mappings.return_value = {
         "https://license_1.com/license": "License 1",
     }
 
-    license_name = get_license_name_from_url(
+    license_title = get_license_title_from_url(
         "https://license_2.com/license", force_refresh=True
     )
 
-    assert license_name is None
+    assert license_title is None