Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[front] add missing breadcrumbs in customization+ fix(#8274) #8420

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

CelineSebe
Copy link
Member

@CelineSebe CelineSebe commented Sep 19, 2024

Proposed changes

  • breadcrumbs in customization

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@CelineSebe CelineSebe self-assigned this Sep 19, 2024
@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Sep 19, 2024
@CelineSebe CelineSebe linked an issue Sep 19, 2024 that may be closed by this pull request
@CelineSebe CelineSebe marked this pull request as ready for review September 19, 2024 09:46
Copy link
Member

@marieflorescontact marieflorescontact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except indentation it looks good

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.15%. Comparing base (d6c9835) to head (cd715d8).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8420      +/-   ##
==========================================
+ Coverage   66.13%   66.15%   +0.01%     
==========================================
  Files         597      597              
  Lines       60374    60374              
  Branches     6191     6193       +2     
==========================================
+ Hits        39931    39941      +10     
+ Misses      20443    20433      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CelineSebe CelineSebe merged commit 5a24ef2 into master Sep 19, 2024
6 checks passed
@CelineSebe CelineSebe deleted the issue/add-missing-breadcrumbs branch September 19, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing breadcrumb in multiple entities/objects overview
2 participants