Improve cache flags. Proper id on auth errors #309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmthomas
requested changes
Dec 5, 2022
| id = Integer(parsed['id']) | ||
| rescue | ||
| OpenC3::Logger.warn("Unable to extract id from JSON-RPC message") | ||
| end |
There was a problem hiding this comment.
I assume you ran into this condition somehow?
| @@ -73,7 +73,7 @@ def self.get_cache_control(filename) | |||
| has_version_number = /(-|_|\.)\d+(-|_|\.)\d+(-|_|\.)\d+\./.match(filename) | |||
| has_content_hash = /\.[a-f0-9]{20}\./.match(filename) | |||
| return nil if has_version_number or has_content_hash | |||
| return 'no-cache' | |||
| return 'no-cache, max-age=3600' | |||
There was a problem hiding this comment.
I had to look this stuff up: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control#request_directives
The no-cache request directive asks caches to validate the response with the origin server before reuse. The max-age=N request directive indicates that the client allows a stored response that is generated on the origin server within N seconds — where N may be any non-negative integer (including 0).
So basically we're saying we allow the server to use a stored response that's less than 1hr old but we always want that response from the server (no local caching). Is that right?
jmthomas
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.