File interface #2005
File interface #2005
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2005 +/- ##
==========================================
+ Coverage 76.87% 77.06% +0.19%
==========================================
Files 638 640 +2
Lines 47462 47765 +303
Branches 754 754
==========================================
+ Hits 36486 36811 +325
+ Misses 10893 10871 -22
Partials 83 83
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -309,7 +312,7 @@ def handle_received_time_extra_and_data(entry, time_nsec_since_epoch, includes_r | |||
| if cbor | |||
| extra = CBOR.decode(extra_encoded) | |||
| else | |||
| extra = JSON.parse(extra_encode, allow_nan: true, create_additions: true) | |||
| extra = JSON.parse(extra_encoded, allow_nan: true, create_additions: true) | |||
There was a problem hiding this comment.
Not sure how we didn't stumble across this bug before
| @file = string_io | ||
| else | ||
| @file = BufferedFile.open(@filename, 'rb') | ||
| end |
There was a problem hiding this comment.
Treating the file as a StringIO made all this work as is
| @data.replace(@data[@extra[:size]..-1]) | ||
| @reduction_state = :START | ||
| end | ||
| end |
There was a problem hiding this comment.
This is the magic @extra that allows this to work across multiple files
| if data and data.length > 0 | ||
| read_interface_base(data, nil) | ||
| return data, nil | ||
| return data, { filename: @filename, size: data.length } |
There was a problem hiding this comment.
This allows the protocol to know when a file is opened
| @reduction_state = :FLAGS_REMOVED | ||
| end | ||
|
|
||
| if @reduction_state == :FLAGS_REMOVED or (@reduction_state == :SYNC_REMOVED and @mode != 4) | ||
| if @reduction_state == :FLAGS_REMOVED |
There was a problem hiding this comment.
I removed references to modes (versions) before COSMOS 4
|
No description provided.