Skip to content

Ensure disconnect called at least once on interface. #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 13, 2024
Merged

Conversation

ryanmelt
Copy link
Member

Make periodic command ensure connected before sending

@ryanmelt ryanmelt requested a review from jmthomas January 10, 2024 23:45
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (0eb17f1) 75.33% compared to head (c75c399) 75.33%.
Report is 10 commits behind head on main.

Files Patch % Lines
openc3/python/openc3/interfaces/interface.py 0.00% 7 Missing ⚠️
openc3/lib/openc3/interfaces/interface.rb 0.00% 5 Missing ⚠️
...hon/openc3/microservices/interface_microservice.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1039      +/-   ##
==========================================
- Coverage   75.33%   75.33%   -0.01%     
==========================================
  Files         590      590              
  Lines       43135    43147      +12     
  Branches      749      749              
==========================================
+ Hits        32496    32503       +7     
- Misses      10561    10566       +5     
  Partials       78       78              
Flag Coverage Δ
python 83.56% <40.00%> (-0.03%) ⬇️
ruby-api 48.69% <ø> (ø)
ruby-backend 80.43% <37.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you have a ruff error but otherwise looks good

Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ryanmelt ryanmelt merged commit 740ba0a into main Jan 13, 2024
@ryanmelt ryanmelt deleted the ensure_disconnect branch January 13, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants