Skip to content

Commit 220bed4

Browse files
authored
Merge pull request #1716 from OpenC3/fix_migrations
Fix migrations
2 parents cf8e782 + 9f975d9 commit 220bed4

File tree

4 files changed

+40
-11
lines changed

4 files changed

+40
-11
lines changed

openc3/bin/openc3cli

+1-1
Original file line numberDiff line numberDiff line change
@@ -523,7 +523,7 @@ def run_migrations(folder)
523523
if extension == '.rb' and not migrations[name]
524524
unless brand_new
525525
puts "Running Migration: #{name}"
526-
require File.join(folder, entry)
526+
require entry
527527
end
528528
OpenC3::MigrationModel.new(name: name).create
529529
end

openc3/lib/openc3/migrations/20241107120000_no_critical_cmd.rb

+8-8
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,16 @@
22
require 'openc3/models/scope_model'
33
require 'openc3/models/microservice_model'
44

5-
begin
6-
require 'openc3-enterprise/models/cmd_authority_model'
7-
require 'openc3-enterprise/models/critical_cmd_model'
8-
BASE = false
9-
rescue LoadError
10-
BASE = true
11-
end
12-
135
module OpenC3
146
class NoCriticalCmd < Migration
7+
begin
8+
require 'openc3-enterprise/models/cmd_authority_model'
9+
require 'openc3-enterprise/models/critical_cmd_model'
10+
BASE = false
11+
rescue LoadError
12+
BASE = true
13+
end
14+
1515
def self.run
1616
if BASE # Only remove the critical command model if we're not enterprise
1717
ScopeModel.get_all_models(scope: nil).each do |scope, scope_model|
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
require 'openc3/utilities/migration'
2+
require 'openc3/models/scope_model'
3+
require 'openc3/models/microservice_model'
4+
5+
module OpenC3
6+
class NoTriggerGroups < Migration
7+
begin
8+
require 'openc3-enterprise/models/cmd_authority_model'
9+
require 'openc3-enterprise/models/critical_cmd_model'
10+
BASE = false
11+
rescue LoadError
12+
BASE = true
13+
end
14+
15+
def self.run
16+
if BASE # Only remove the trigger group microservice if we're not enterprise
17+
MicroserviceModel.get_all_models(scope: 'DEFAULT').each do |microservice_name, microservice_model|
18+
if microservice_name =~ /__TRIGGER_GROUP__/
19+
microservice_model.destroy
20+
end
21+
end
22+
end
23+
end
24+
end
25+
end
26+
27+
unless ENV['OPENC3_NO_MIGRATE']
28+
OpenC3::NoTriggerGroups.run
29+
end

openc3/lib/openc3/models/scope_model.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -74,13 +74,13 @@ def self.all(scope: nil)
7474
super(PRIMARY_KEY)
7575
end
7676

77-
def self.from_json(json)
77+
def self.from_json(json, scope: nil)
7878
json = JSON.parse(json, :allow_nan => true, :create_additions => true) if String === json
7979
raise "json data is nil" if json.nil?
8080
self.new(**json.transform_keys(&:to_sym))
8181
end
8282

83-
def self.get_model(name:)
83+
def self.get_model(name:, scope: nil)
8484
json = get(name: name)
8585
if json
8686
return from_json(json)

0 commit comments

Comments
 (0)