Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @tailwindlabs/headlessui lib when available #246

Closed
3 tasks
vnugent opened this issue Mar 29, 2022 · 2 comments
Closed
3 tasks

Upgrade @tailwindlabs/headlessui lib when available #246

vnugent opened this issue Mar 29, 2022 · 2 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@vnugent
Copy link
Contributor

vnugent commented Mar 29, 2022

Background:

In LeanPopover.tsx the onClick should have been on Popover.Button. But due to a bug, the button ignores user-defined onClick prop.

        <div onClick={onApply}> 
          <Popover.Button className='text-primary-contrast bg-slate-800 rounded-md px-2 py-0.5'>
            {btnApplyLabel}
          </Popover.Button>
        </div>

To do:

@vnugent vnugent added good first issue Good for newcomers help wanted Extra attention is needed labels Mar 29, 2022
@vnugent vnugent added this to the v0.3 milestone Mar 29, 2022
@tittaenalg
Copy link
Contributor

Hey @vnugent, didn't see a way to assign this issue to myself, but created a pull request to address it: #300

This is my first PR for open-tacos, so let me know if I missed any steps in the process.

@vnugent
Copy link
Contributor Author

vnugent commented May 5, 2022

I think only project's team members with Write permission can assign issues. I'm going to send you an invite. Thanks for the PR!

@vnugent vnugent closed this as completed May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants