Skip to content
This repository has been archived by the owner on May 16, 2019. It is now read-only.

Reputation functions to add before v1 mainnet launch #840

Closed
1 of 2 tasks
drwasho opened this issue Feb 29, 2016 · 6 comments
Closed
1 of 2 tasks

Reputation functions to add before v1 mainnet launch #840

drwasho opened this issue Feb 29, 2016 · 6 comments
Assignees

Comments

@drwasho
Copy link
Member

drwasho commented Feb 29, 2016

Unfinished sub-task from #472

  • Display additional rating detail on the listing's Reviews tab
    • OPTIONAL
      • GUID of the node who rated the tx (active link to their store, if they're available)
      • Button to show JSON backend of the rating data (aka transaction summary)
    • MANDATORY
      • Display either a URL or button that links to the escrow transaction on Blockcypher
  • Display aggregate rating data on a user's page post v1 requirement
@drwasho drwasho added this to the v1.X - Future priority milestone Feb 29, 2016
@drwasho drwasho modified the milestones: v1.X - Future priority, v1.0 - Mainnet Release Mar 4, 2016
@drwasho
Copy link
Member Author

drwasho commented Mar 5, 2016

Server link OpenBazaar/OpenBazaar-Server#270

@rmisio
Copy link
Collaborator

rmisio commented Mar 9, 2016

@drwasho @cpacia
Re: Display aggregate rating data on a user's page

I think we would need this calculation done on the server. For the client to do it, the client would need to loop through all the items in a user's store and for each one make an API request to get all the reviews for that item.

So, consider a store with a 100 items, each containing an average of 500 reviews. Not only would you have 100 HTTP requests, but these payloads would be pretty large (what if an item has 5000 reviews..??).

Further-furthermore, this would be repeated each time the item page is loaded.

Any approach to implement this on the client would be incredibly inefficient and / or complex.

I've made a server side issue:
OpenBazaar/OpenBazaar-Server#283

@drwasho
Copy link
Member Author

drwasho commented Mar 10, 2016

Agreed.

@drwasho
Copy link
Member Author

drwasho commented Mar 17, 2016

Ok, did a little research. This is an example of the response to a get_ratings call:

{
    "signature": "H9zpuirYQ82zzlDdQ13S4CiMj4o2aezT0JbCLLw5gx2gMHQ3elR/RlEyw9lXQTvXWkA7yh2U1SKeU/iug/qkLV8=",
    "tx_summary": {
      "delivery_time": "5",
      "buyer_key": "03d1a9b222c85aa306cf49f1b6ded6d86a1a5850359622aad04d9b4d60c73a77ae",
      "feedback": "5",
      "review": "I like dresses",
      "listing": "c8d1ff75d916aaa2bd0040ffa9b4552b9b720ee9",
      "customer_service": "5",
      "amount": 0.01,
      "address": "mfsYWTUTXwgrrEcVb72Z65GKf7nrMJqZxk",
      "quality": "5",
      "proof_of_tx": "c0AMge0ZELxt/tbxv/Wkwyn1dhWV/fmqpjgQ5ir9gpzn8NWIiTgoqnWWYqAIRMuNvzkhnCR+Ir/T59xumU5+Dg==",
      "description": "5"
    }
  }

What I think we should display is a button that links out to the address value via Blockcypher... perhaps something like this:

image

@morebrownies this could definitely use your talents.

@jjeffryes
Copy link
Contributor

Closed in #1189

@jjeffryes jjeffryes self-assigned this Mar 25, 2016
@drwasho
Copy link
Member Author

drwasho commented Mar 26, 2016

Great job Josh

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants