Skip to content
This repository has been archived by the owner on May 16, 2019. It is now read-only.

Wire up filter in following/followers tab of User View #592

Closed
jjeffryes opened this issue Jan 27, 2016 · 5 comments
Closed

Wire up filter in following/followers tab of User View #592

jjeffryes opened this issue Jan 27, 2016 · 5 comments

Comments

@jjeffryes
Copy link
Contributor

The select box that allows filtering followers/following by type should be coded on the following/followers tab of the User View

@jjeffryes
Copy link
Contributor Author

This requires changes to the get_following and get_followers API calls, currently neither one returns the data needed to filter the follower or following lists.

@jjeffryes
Copy link
Contributor Author

If the API isn't updated before launch, the select boxes for filtering should be hidden.

@drwasho drwasho added this to the v1.0 - Stretch Goal milestone Feb 1, 2016
@drwasho
Copy link
Member

drwasho commented Feb 29, 2016

@jjeffryes don't forget about this one... probably should remove the filter dropdown and add the v1 mainnet requirement tag.

@drwasho drwasho modified the milestones: v1.0 - Stretch Goal, v1.0 - Mainnet Release Mar 4, 2016
@drwasho drwasho removed this from the v1.0 - Mainnet Release milestone Apr 26, 2016
@SamPatt
Copy link
Member

SamPatt commented May 25, 2016

@jjeffryes With the recent changes to following is this issue obsolete?

@jjeffryes
Copy link
Contributor Author

The backend doesn't support this kind of filtering, both due to the data not being available in get_followers/get_following and due to lazy loading (ie: it could only filter the loaded data).

I recommend this be closed. We should discuss whether we want some kind of filtering/searching of followers, and what that would require in a new API.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants