-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variable Recurring Payments (VRPs) for v3.1.8 #36
Comments
- Reuse existing classes within payments/accounts as much as possible, to avoid duplication Issue: OpenBankingToolkit/openbanking-toolkit#36
- There are no request parameters in v3.1.8 of the VRP swagger spec, meaning the generated code did not have any request body objects or headers. I have added the request body objects manually, but they may not e correct. - I assume this is a mistake in the swagger spec and have created this issue: OpenBankingUK/read-write-api-specs#51 - As per other controllers in the Read/Write API, a number of annotations (e.g. @PreAuthorize and @OpenBankingAPI) need adding. I have inserted them in commented out sections, but certain things (e.g. the scopes) may not be correct. Issue: OpenBankingToolkit/openbanking-toolkit#36
- There are no request parameters in v3.1.8 of the VRP swagger spec, meaning the generated code did not have any request body objects or headers. I have added the request body objects manually, but they may not e correct. - I assume this is a mistake in the swagger spec and have created this issue: OpenBankingUK/read-write-api-specs#51 - As per other controllers in the Read/Write API, a number of annotations (e.g. @PreAuthorize and @OpenBankingAPI) need adding. I have inserted them in commented out sections, but certain things (e.g. the scopes) may not be correct. Issue: OpenBankingToolkit/openbanking-toolkit#36
- There are no request parameters in v3.1.8 of the VRP swagger spec, meaning the generated code did not have any request body objects or headers. I have added the request body objects manually, but they may not e correct. - I assume this is a mistake in the swagger spec and have created this issue: OpenBankingUK/read-write-api-specs#51 - As per other controllers in the Read/Write API, a number of annotations (e.g. @PreAuthorize and @OpenBankingAPI) need adding. I have inserted them in commented out sections, but certain things (e.g. the scopes) may not be correct. Issue: OpenBankingToolkit/openbanking-toolkit#36
Create Variable Recurring Payments Consent Revocation Dashboard VRP allows PSUs to Revoke existing VRP agreements via the TPP application. |
Create a VRP consent page Variable Recurring Payments requires new constent pages. |
Create Bank VRP revocation pages In the VRP specifications and Guidelines the ASPSP must support a flow that allows the PSU to authorize with the bank and then review all VRP consents and revoke them. |
@jorgesanchezperez and I have decided that we don't need to implement the VRP dashboard for a TPP. We also don't need to support the pages that allow a PSU to use the bank pages to revoke VRPs. This is because;
|
Generate VRP datamodels and controllers. Using the latest swagger files, generate data classes (models) and controllers. |
- There are no request parameters in v3.1.8 of the VRP swagger spec, meaning the generated code did not have any request body objects or headers. I have added the request body objects manually, but they may not e correct. - I assume this is a mistake in the swagger spec and have created this issue: OpenBankingUK/read-write-api-specs#51 - As per other controllers in the Read/Write API, a number of annotations (e.g. @PreAuthorize and @OpenBankingAPI) need adding. I have inserted them in commented out sections, but certain things (e.g. the scopes) may not be correct. Issue: OpenBankingToolkit/openbanking-toolkit#36
- There are no request parameters in v3.1.8 of the VRP swagger spec, meaning the generated code did not have any request body objects or headers. I have added the request body objects manually, but they may not e correct. - I assume this is a mistake in the swagger spec and have created this issue: OpenBankingUK/read-write-api-specs#51 - As per other controllers in the Read/Write API, a number of annotations (e.g. @PreAuthorize and @OpenBankingAPI) need adding. I have inserted them in commented out sections, but certain things (e.g. the scopes) may not be correct. Issue: OpenBankingToolkit/openbanking-toolkit#36
Create VRP datamodel from 3.1.9r3 swagger definition. Jorge and I have reviewed the changes in the 3.1.9r3 VRP swagger spec, and there a no new objects or anything, just a much more complete model with enums defined and better sharing of classes rather than nesting. So, we think we will generate the data model from the 3.1.9r3 swagger spec and use that datamodel to implement the 3.1.8 controllers. This should make the move the 3.1.9 trivial too. |
- Added new properties on configuration to get the aspsp name of the platform - Updated some dependecies with SNAPSHOT to support development iteration for branch 36 (must be update before merge on master) Issue: OpenBankingToolkit/openbanking-toolkit#36
In accord with this spec; https://openbankinguk.github.io/read-write-api-site3/v3.1.8/resources-and-data-models/vrp/domestic-vrps.html#post-domestic-vrps Each VRP request need to test that the initiation and risk objects match those that were provided when the consent was created. Issue: OpenBankingToolkit/openbanking-toolkit#36
In accord with this spec; https://openbankinguk.github.io/read-write-api-site3/v3.1.8/resources-and-data-models/vrp/domestic-vrps.html#post-domestic-vrps Each VRP request need to test that the initiation and risk objects match those that were provided when the consent was created. Issue: OpenBankingToolkit/openbanking-toolkit#36
Add filters to ensure that Creditor is provided in the request if it doesn't exist in the consent Issue: OpenBankingToolkit/openbanking-toolkit#36
* 45: Add VRP generated API and Controllers Issue: OpenBankingToolkit/openbanking-toolkit#45 * commit before rebase master * 45: Use latest uk-datamodel with 3.1.8r5 swagger models Some changes to VRP and Funds Conformation Issue: OpenBankingToolkit/openbanking-toolkit#45 * Release candidate: prepare release 1.5.6 * Release candidate: prepare for next development iteration * after rebase master * 47: vrp consent controllers - Fix simbols - Fix Shortcuts annotations in VRP controller interfaces Issue: OpenBankingToolkit/openbanking-toolkit#47 * 47: VRP consent controllers - Fix VRP request Mapping controllers annotation Issue: OpenBankingToolkit/openbanking-toolkit#47 * Intermediate checkin with new 3.1.9r3 datamodels (#462) Some of the Consent stuff doesn't compile, but the VRP side now compiling * 47: vrp consent controllers (#463) * 47: vrp consent controllers - First approach to implement the consent controllers Issue: OpenBankingToolkit/openbanking-toolkit#47 * Delete uk-datamodel snapshot to use the parent snapshot in the development iteration of VRP payments * Delete uk-datamodel snapshot to use the parent snapshot in the development iteration of VRP payments * 47: vrp payment consent controller (#464) * 47: vrp consent controllers - rebase - First approach to implement the consent controllers Issue: OpenBankingToolkit/openbanking-toolkit#47 * Delete uk-datamodel snapshot to use the parent snapshot in the development iteration of VRP payments * Delete uk-datamodel snapshot to use the parent snapshot in the development iteration of VRP payments * 47: vrp payment consent controller - Updated discovery configuration - Updated resource link service to introduce the vrp links - Other improvements for vrp consent Issue: OpenBankingToolkit/openbanking-toolkit#47 * 48: Develop DomesticVrpApi and controllers Hand over to Jorge! Issue: OpenBankingToolkit/openbanking-toolkit#48 * Issue/47 implementation of vrp payment consent controller (#466) * 47: vrp consent controllers - rebase - First approach to implement the consent controllers Issue: OpenBankingToolkit/openbanking-toolkit#47 * Delete uk-datamodel snapshot to use the parent snapshot in the development iteration of VRP payments * Delete uk-datamodel snapshot to use the parent snapshot in the development iteration of VRP payments * Added store IT test * 36-47: VRP payment consent controller - Added Integration tests for VRP payment consent - Few fixes Issue: OpenBankingToolkit/openbanking-toolkit#47 * 36-47: VRP consent controller flow - Added implementation to consent details and decision to present data on Bank UI - Added implementation consent operations (Post, Get, delete) - Added Integration tests - Set the proper snapshot dependencies for development iteration on branch 36 (must be updated before merge on master) Issue: OpenBankingToolkit/openbanking-toolkit#47 * VRP Funds confirmation * Fix Domestic consent controller constructor to delete unused service * Fix integration tests for VRP funds confirmation * 36: Add filters to test vrp Payments risk and initiation In accord with this spec; https://openbankinguk.github.io/read-write-api-site3/v3.1.8/resources-and-data-models/vrp/domestic-vrps.html#post-domestic-vrps Each VRP request need to test that the initiation and risk objects match those that were provided when the consent was created. Issue: OpenBankingToolkit/openbanking-toolkit#36 * 36: Further VRP request filters Add filters to ensure that Creditor is provided in the request if it doesn't exist in the consent Issue: OpenBankingToolkit/openbanking-toolkit#36 * 36-48: VRP payment controller validations Issue: OpenBankingToolkit/openbanking-toolkit#48 * Vrp payment submission controller and integration tests * vrp payment contrller gateway server implementations * Fix node version github workflow to build and tests the UIs * Update version to 1.6.0 * Fix npm tests for VRP payment component Co-authored-by: JamieB <jamie.bowen@forgerock.com> Co-authored-by: Jamie Bowen <jpublic@chantrycottage.net>
* 36: Variable recurring payments support - Added new properties on configuration to get the aspsp name of the platform - Updated some dependecies with SNAPSHOT to support development iteration for branch 36 (must be update before merge on master) Issue: OpenBankingToolkit/openbanking-toolkit#36 * Added descriptions on new platorm configuration properties * Latests version or dependencies
- Fix Discovery links for VRP payment Issue: OpenBankingToolkit/openbanking-toolkit#36
- Fix Discovery links for VRP payment Issue: OpenBankingToolkit/openbanking-toolkit#36
- Bumped latest dependencies - Few fixes to support VRP payments Issue: OpenBankingToolkit/openbanking-toolkit#36
- Bumped latest dependencies - Few fixes to support VRP payments Issue: OpenBankingToolkit/openbanking-toolkit#36
- Bumped starter parent 1.2.8 - Bumped commons 1.3.1 - Bumped clients 1.3.1 - Bumped jwkms 1.3.1 - Bumped auth 1.3.1 - Bumped directory 1.6.1 - Bumped analytics 1.4.1 - Bumped aspsp 1.6.0 - Bumped uk-extensions 1.6.0 Issue: OpenBankingToolkit/openbanking-toolkit#36
* 36: Variable recurring payments support - Added new properties on configuration to get the aspsp name of the platform - Updated some dependecies with SNAPSHOT to support development iteration for branch 36 (must be update before merge on master) Issue: OpenBankingToolkit/openbanking-toolkit#36 * Added descriptions on new platorm configuration properties * Latests version or dependencies * 36: VRP payment support - Bumped starter parent 1.2.8 - Bumped commons 1.3.1 - Bumped clients 1.3.1 - Bumped jwkms 1.3.1 - Bumped auth 1.3.1 - Bumped directory 1.6.1 - Bumped analytics 1.4.1 - Bumped aspsp 1.6.0 - Bumped uk-extensions 1.6.0 Issue: OpenBankingToolkit/openbanking-toolkit#36
RELEASE NOTES New Features ============ Variable Recurring Payments for v3.1.8 OpenBankingToolkit/openbanking-toolkit#36 Customer Info endpoint - ForgeCloud/ob-deploy#815 Fixes issue =========== Payment Submission redirection does not meet customer experience guildelines - ForgeCloud/ob-deploy#794 Ability to create an app Manually is failing ForgeCloud/ob-deploy#830 User data get's created against TPP, not against PSU user ForgeCloud/ob-deploy#831
Closing. We now just need a solution for #50 |
Story
As a customer of the OB Toolkit
I want to be able to use VRPs
so that I can be sure I am compliant with the latest OB specifications.
Acceptance criteria
Tasks
application.yml
- with active/inactive API versions).Estimate 14 days effort. Say 17 man days of effort with a bit of wriggle room.
Release Notes
Affected Apps:
The text was updated successfully, but these errors were encountered: