feat(chrome_extension): write dom changes to database (using sockets) during openadapt.record #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge main into test_extension
KrishPatel13
changed the title
|
@0dm @KrishPatel13 can you please remind me what is the status on this? |
This was referenced Jun 7, 2024
abrichr
reviewed
Jul 12, 2024
| from openadapt import config, sockets | ||
|
|
||
| SOCKETS = True | ||
| DBG_DATABASE = False |
There was a problem hiding this comment.
Can you please clarify what this is for?
abrichr
reviewed
Jul 12, 2024
|
|
||
| from openadapt import config, sockets | ||
|
|
||
| SOCKETS = True |
|
@KrishPatel13 I believe this should be closed in favor of #744, can you please confirm? |
Yes!, closing as a new PR is launched for this here: #744 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR implements the chrome extension to write the DOM changes (documents' outer HTML of Head and Body and the url) in database.
Summary
Motivation: Related Issue: #51
Checklist
How can your code be run and tested?
Other information