Fix DevContainer by switching from moby to docker #22725
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you currently try to open the repo in a DevContainer or a Github Codespace the creation of the container fails:
This PR fixes this by disabling moby and using docker instead. Other potential fixes seemed not be fine to me:
debian:bookworm: trixie is stable since August 2025. We should use the most recent stable Debianubuntu-24.04: Would still be the recent release, however, not for long anymore. But the actual issue is, that the DevContainer featureghcr.io/snebjorn/devcontainer-feature/chromium:latestdoes only seem to work on Debian. The creation with Ubuntu failed.After disabling moby, the DevContainer worked for me as expected. Also docker-in-docker just worked. The script
run-in-docker.shcan be run successfully. I’m not aware of what else relies on the docker-in-docker feature, as the commit (1ce95ff/#17095) that introduced it does not explain why it was added in the first place. It’s possible that something is broken due to the switch from moby to docker, but at least the container is functioning again instead of failing to start altogether.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Fix DevContainer and Codespaces startup on Debian trixie by switching the docker-in-docker feature from Moby to Docker.
Written for commit db9932f. Summary will update on new commits.