Fixed scala-sttp4-jsoniter compilation error: replace .getRight with .orFail

[pielas]

Fixes #22047

Summary

The scala-sttp4-jsoniter generator produces non-compiling Scala 3 code when separateErrorChannel=false is set. The generated code uses .getRight which was removed from STTP4 between versions 4.0.0-M1 and 4.0.0-RC1.

Motivation

STTP library changed its API between milestone and RC releases:

• Removed: .getRight and .getEither extension methods
• Replaced with: .orFail and .orFailDeserialization methods
• Reference: STTP v3 to v4 Migration Guide

The openapi-generator templates were not updated to reflect this breaking change, causing compilation failures for all generated clients using STTP 4.0.0-RC1+.

Changes

• Updated api.mustache template in modules/openapi-generator/src/main/resources/scala-sttp4-jsoniter/ and replaced .getRight with .orFail when separateErrorChannel=false

Reproduction Steps

1. Create test spec (test-api.yaml):

openapi: 3.0.0
info:
  title: Test API
  version: 1.0.0
servers:
  - url: https://api.example.com
paths:
  /test:
    post:
      operationId: testOperation
      responses:
        '204':
          description: No content
        '400':
          description: Bad request
          content:
            application/json:
              schema:
                type: object

2. Config file (config.yaml):
   separateErrorChannel: false

3. Generate client:

openapi-generator generate \
   -i test-api.yaml \
   -g scala-sttp4-jsoniter \
   -o generated \
   -c config.yaml

4. Compile (fails before fix):
   cd generated && sbt compile

[wing328]

thanks for the fix

i could repeat the issue locally

$ sbt compile
[info] welcome to sbt 1.9.9 (Eclipse Adoptium Java 17.0.16)
[info] loading project definition from C:\Users\User\AppData\Local\Temp\sc\project
[info] loading settings for project sc from build.sbt ...
[info] set current project to openapi-client (in build file:/C:/Users/User/AppData/Local/Temp/sc/)
[info] Executing in batch mode. For better performance use sbt's shell
[info] compiling 1 Scala source to C:\Users\User\AppData\Local\Temp\sc\target\scala-3.3.4\classes ...
[error] -- [E008] Not Found Error: C:\Users\User\AppData\Local\Temp\sc\src\main\scala\org\openapitools\client\api\DefaultApi.scala:64:95
[error] 64 |      .response(asString.mapWithMetadata(ResponseAs.deserializeRightWithError(_ => Right(()))).getRight)
[error]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[error]    |value getRight is not a member of sttp.client4.ResponseAs[Either[sttp.client4.ResponseException[String], Unit]] - did you mean sttp.client4.ResponseAs[Either[sttp.client4.ResponseException[String], Unit]].mapRight
[error] one error found
[error] (Compile / compileIncremental) Compilation failed
[error] Total time: 3 s, completed Dec 13, 2025, 6:49:00 PM

and confirmed the fix