-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
[kotlin] fix query parameter encoding (reverted) #22512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I had expected the generated code in samples>echo_api to be modified after runner the sample generators. But it didn't. If someone can explain why it didn't, I would like to hear it. |
|
cc @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) @stefankoppier (2022/06) @e5l (2024/10) |
|
thanks again for the pr did you test this fix locally to confirm it works for your use cases? |
Yes, I have and it is working. |
* OpenAPITools#22339 fix query parameter encoding * OpenAPITools#22339 fix query parameter encoding * OpenAPITools#22339 ran generate-samples with some local adaptations --------- Co-authored-by: AlbertWaninge <albert.waninge@edsn.nl>
|
This broke handling the most basic query params: turns |
This is a test for a regression from OpenAPITools#22512 where param values were written as a list.
|
Also broke handling of preconfigured base URLs, see e.g. #22631 |
* [kotlin] Add integration test for query params This is a test for a regression from #22512 where param values were written as a list. * add test implementation for kotlin spring client * add sha tests --------- Co-authored-by: Piotr Kubowicz <piotr.kubowicz@gmail.com>
This is a test for a regression from #22512 where param values were written as a list.
|
thanks for reviewing the change reverted via #22727 |
|
This actually killed one specific feature in our web app after out CI automatically updated dependencies (it does that for minor version changes). Kotlin Backend and Angular frontend. Took a while to find out what was going on. 7.19.0 fixed it, thanks. |
to close #22339
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)