Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX][PHP-NEXTGEN] Missing tagged union discriminator literal (#20343) #20356

Merged
merged 2 commits into from
Dec 22, 2024

Conversation

brianferri
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.

  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.

    • To validate please read and use the specifications provided in the linked issue
  • Run the following to build the project and update samples:

    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    

    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.

  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)

  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ybelenko (2018/07), @renepardon (2018/12)

brianferri and others added 2 commits December 19, 2024 15:40
chore: build and package

---------

Co-authored-by: Christian Ascone <ascone.christian@gmail.com>
@brianferri brianferri changed the title fix: Missing tagged union discriminator literal (https://github.com/OpenAPITools/openapi-generator/issues/20343) [FIX][PHP-NEXTGEN] Missing tagged union discriminator literal (https://github.com/OpenAPITools/openapi-generator/issues/20343) Dec 19, 2024
@brianferri brianferri changed the title [FIX][PHP-NEXTGEN] Missing tagged union discriminator literal (https://github.com/OpenAPITools/openapi-generator/issues/20343) [FIX][PHP-NEXTGEN] Missing tagged union discriminator literal (#20343) Dec 19, 2024
@wing328
Copy link
Member

wing328 commented Dec 21, 2024

@brianferri thanks for the PR

can you please briefly describe the issue?

@brianferri
Copy link
Contributor Author

brianferri commented Dec 21, 2024

@brianferri thanks for the PR

can you please briefly describe the issue?

Of course, @wing328.
For a more detailed overview: #20343

The PHP generators, when generating tagged unions dont generate all the correct discriminator mapping values.

This is because the part that should have handled this didn't exist previously in the generic model template.

The PR adds the missing part of the template for the generation of mapped models for the discriminator values in the case of a tagged union model

(This is something that other generators already do, tested with Java, python, typescript generators)

@wing328
Copy link
Member

wing328 commented Dec 22, 2024

FYI @JulianVennen as well who's been making a lot of improvements to php-nextgen client generator.

@wing328 wing328 merged commit 401c8d0 into OpenAPITools:master Dec 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants