[Java] Fix compilation error for a Map<String, Set<InnerEnum>> due to incompatible types #19401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bragolgirith
changed the title
Bragolgirith
force-pushed
the
java-fix-compilation-for-map-of-collection-of-enum
branch
from
25ee253
to
940cab5
Compare
Bragolgirith
force-pushed
the
java-fix-compilation-for-map-of-collection-of-enum
branch
from
940cab5
to
d7d5713
Compare
wing328
changed the title
wing328
reviewed
Aug 28, 2024
| enum: | ||
| - DEVELOPER | ||
| - TESTER | ||
| - OWNER |
There was a problem hiding this comment.
i did a test with this spec but still got errors:
[ERROR] C:\Users\wing3\AppData\Local\Temp\java-enum\src\main\java\org\openapitools\client\model\Employee.java:[118,9] error: enum InnerEnum is already defined in class Employee
[ERROR] C:\Users\wing3\AppData\Local\Temp\java-enum\src\main\java\org\openapitools\client\JSON.java:[49,7] error: duplicate class: org.openapitools.client.JSON
can you please take a look?
command:
java -jar modules/openapi-generator-cli/target/openapi-generator-cli.jar generate -g java -i modules/openapi-generator/src/test/resources/3_0/issue_19393_map_of_inner_enum.yaml -o /tmp/java-enum/
There was a problem hiding this comment.
Oh, sorry about that!
The errors seem to be due to a different bug where the same name (InnerEnum) gets generated for multiple enums within the same schema.
I've now updated the test spec to use two different schemas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… incompatible types.
Fixes #19393.