-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REQ] Rust generated code should follow Clippy suggestions #7270
Comments
Good idea 👍 We just did the same for the C petstore client using a different code analysis tool. I wonder if you can put the full report here so that the community can work on these issues reported by Clippy one by one. Thank you. |
Well, that will be a long list, but the main problems are the two mentioned:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Now, when using
cargo clippy
to check the generated code, some bad smell may raise.For example, when running
cargo clippy --all-targets --all-features --allow-dirty --allow-staged --fix -Z unstable-options -- -D warnings
, the following warning may raise:About naming
About rules like
new_without_default
Describe the solution you'd like
More strict lint test is needed when testing the generator
Describe alternatives you've considered
No alternative
Additional context
You can test by using the following schema: https://github.com/ory/hydra/blob/master/.schema/config.schema.json
The text was updated successfully, but these errors were encountered: