Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Overflow in maximum value validator (python and others) #12565

Open
5 of 6 tasks
dylex opened this issue Jun 9, 2022 · 0 comments
Open
5 of 6 tasks

[BUG] Overflow in maximum value validator (python and others) #12565

dylex opened this issue Jun 9, 2022 · 0 comments

Comments

@dylex
Copy link

dylex commented Jun 9, 2022

Bug Report Checklist

  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Sponsorship to speed up the bug fix or feature request (example)
Description

With a schema like this:

"item": {
  "maximum": 18446744073709551615,
  "type": "integer",
  "minimum": 0
}

The python generator produces a validator like this:

      validations = {
          ('value',): {
              'inclusive_maximum': -1,
              'inclusive_minimum': 0,
          },
      }

It seems like that maximum value is overflowing. (These ranges are automatically generated by my openapi library for uint64_t types.) This also affects a number of other generators I've tried.

openapi-generator version
>docker run --rm openapitools/openapi-generator-cli version
6.0.1-SNAPSHOT
OpenAPI declaration file content or url
{"openapi":"3.0.0","info":{"version":"2.0","title":"Test API"},"servers":[{"url":"http://localhost:8092/api"}],"paths":{"/":{"get":{"operationId":"top","responses":{"200":{"$ref":"#/components/responses/top"}}}}},"components":{"schemas":{"item":{"maximum":18446744073709551615,"type":"integer","minimum":0}},"responses":{"top":{"description":"top result","content":{"application/json":{"schema":{"items":{"$ref":"#/components/schemas/item"}}}}}}}}
Generation Details
docker run -v $PWD:/data --rm openapitools/openapi-generator-cli generate -i /data/openapi.json -g python -o /data/python
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants