Skip to content

Commit 8eb31d0

Browse files
authored
minor improvements to php-dt generator (#10159)
1 parent 87554ec commit 8eb31d0

File tree

2 files changed

+17
-7
lines changed

2 files changed

+17
-7
lines changed

docs/generators.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,13 @@ The following generators are available:
4646
* [k6 (beta)](generators/k6.md)
4747
* [kotlin](generators/kotlin.md)
4848
* [lua (beta)](generators/lua.md)
49+
* [micronaut-client](generators/micronaut-client.md)
4950
* [nim (beta)](generators/nim.md)
5051
* [objc](generators/objc.md)
5152
* [ocaml](generators/ocaml.md)
5253
* [perl](generators/perl.md)
5354
* [php](generators/php.md)
54-
* [php-dt](generators/php-dt.md)
55+
* [php-dt (beta)](generators/php-dt.md)
5556
* [powershell (beta)](generators/powershell.md)
5657
* [python (experimental)](generators/python.md)
5758
* [python-legacy](generators/python-legacy.md)

modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/PhpDataTransferClientCodegen.java

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,12 @@
2727
import io.swagger.v3.oas.models.parameters.RequestBody;
2828
import io.swagger.v3.oas.models.responses.ApiResponse;
2929
import io.swagger.v3.oas.models.responses.ApiResponses;
30-
import org.openapitools.codegen.*;
30+
import org.openapitools.codegen.CodegenConstants;
31+
import org.openapitools.codegen.CodegenOperation;
32+
import org.openapitools.codegen.CodegenType;
33+
import org.openapitools.codegen.SupportingFile;
34+
import org.openapitools.codegen.meta.GeneratorMetadata;
35+
import org.openapitools.codegen.meta.Stability;
3136
import org.openapitools.codegen.meta.features.*;
3237
import org.openapitools.codegen.utils.ModelUtils;
3338
import org.slf4j.Logger;
@@ -63,7 +68,7 @@ public String getName() {
6368

6469
@Override
6570
public String getHelp() {
66-
return "Generates PHP client relying on Data Transfer ( https://github.com/Articus/DataTransfer ) and compliant with PSR-7, PSR-11, PSR-17 and PSR-18.";
71+
return "Generates a PHP client relying on Data Transfer ( https://github.com/Articus/DataTransfer ) and compliant with PSR-7, PSR-11, PSR-17 and PSR-18.";
6772
}
6873

6974
public PhpDataTransferClientCodegen() {
@@ -83,6 +88,10 @@ public PhpDataTransferClientCodegen() {
8388
)
8489
);
8590

91+
generatorMetadata = GeneratorMetadata.newBuilder(generatorMetadata)
92+
.stability(Stability.BETA)
93+
.build();
94+
8695
//no point to use double - http://php.net/manual/en/language.types.float.php , especially because of PHP 7+ float type declaration
8796
typeMapping.put("double", "float");
8897

@@ -359,7 +368,7 @@ protected void generateContainerSchemas(OpenAPI openAPI) {
359368
* Generate additional model definitions for containers in specified schema
360369
*
361370
* @param openAPI OpenAPI object
362-
* @param schema OAS schema to process
371+
* @param schema OAS schema to process
363372
*/
364373
protected void generateContainerSchemas(OpenAPI openAPI, Schema schema) {
365374
if (schema != null) {
@@ -371,7 +380,7 @@ protected void generateContainerSchemas(OpenAPI openAPI, Schema schema) {
371380
//Recursively process all schemas of object properties
372381
Map<String, Schema> properties = schema.getProperties();
373382
if (properties != null) {
374-
for (String propertyName: properties.keySet()) {
383+
for (String propertyName : properties.keySet()) {
375384
generateContainerSchemas(openAPI, properties.get(propertyName));
376385
}
377386
}
@@ -415,7 +424,7 @@ protected void quoteMediaTypes(OpenAPI openAPI) {
415424
PathItem path = paths.get(pathname);
416425
List<Operation> operations = path.readOperations();
417426
if (operations != null) {
418-
for (Operation operation: operations) {
427+
for (Operation operation : operations) {
419428
RequestBody requestBody = ModelUtils.getReferencedRequestBody(openAPI, operation.getRequestBody());
420429
if (requestBody != null) {
421430
requestBody.setContent(copyWithQuotedMediaTypes(requestBody.getContent()));
@@ -435,7 +444,7 @@ protected Content copyWithQuotedMediaTypes(Content content) {
435444
Content result = null;
436445
if (content != null) {
437446
result = new Content();
438-
for (String mediaType: content.keySet()) {
447+
for (String mediaType : content.keySet()) {
439448
result.addMediaType("'" + mediaType + "'", content.get(mediaType));
440449
}
441450
}

0 commit comments

Comments
 (0)