Support parsing custom field values and attach to model during retrieval #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moon-brillar
deleted the
support-parsing-custom-field-values-and-attach-to-model-during-retrieval
branch
ericHao22
approved these changes
Jun 16, 2023
| */ | ||
| public function loadCustomFieldValues(): void | ||
| { | ||
| if (! $this->customFieldValues) { |
There was a problem hiding this comment.
這個attribute拿出來應該是個collection？collection就算是空的做boolean判斷也還會是true，所以可能要用collection的方法去判斷是否為空
|
|
||
| $this->customFieldValues->each(function (CustomFieldValue $customFieldValue) { | ||
| $attribute = $customFieldValue->customField->key; | ||
| $this->setAttribute($attribute, $customFieldValue->customField->parseValue($customFieldValue->value)); |
There was a problem hiding this comment.
💬 comment
如果改用setRawAttributes看起來是不經過額外的檢查就set進去，不過這樣就得先跟原來的attributes merge起來再set進去
| @@ -14,4 +14,10 @@ public function getValidationRule(): array | |||
| $this->key => ['boolean'], | |||
| ]; | |||
| } | |||
|
|
|||
| public function parseValue($value): bool | |||
| @@ -14,4 +15,8 @@ public function getValidationRule(): array | |||
| $this->key => ['date'], | |||
| ]; | |||
| } | |||
| public function parseValue($value): string | |||
| { | |||
| return Carbon::parse($value)->toDateTimeString(); | |||
There was a problem hiding this comment.
💬 comment
這樣感覺大部分情況轉換前後都是一樣？要考慮回傳Carbona嗎？
| ``` | ||
|
|
||
| ```php | ||
| use OnrampLab\CustomFields\Concerns\Customizable; |
|
|
||
| - **Validation and Error Handling**: The package provides validation capabilities for custom fields, allowing you to validate user input based on the defined rules. It also handles error handling and validation messages in line with Laravel's validation system. | ||
|
|
||
| - **Extensibility**: The package is built with extensibility in mind. You can easily extend and customize its functionality to meet your specific needs by leveraging Laravel's powerful features such as model events, custom validation rules, and more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.