Support validate custom fields and save custom field values #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenghung
reviewed
May 31, 2023
| $attributes = ['zip_code' => '67890']; | ||
| $this->user->fill($attributes); | ||
| $this->user->save(); | ||
| $customFieldValue = $this->user->customFieldValues()->where('custom_field_id', $this->customField->id)->first(); |
There was a problem hiding this comment.
❓ 這個package有機會支援類似下面的語法嗎？
// syntax
$model->getCustomAttribute('attr-name');
// examples: if lead has "zip_code" custom field
$lead->getCustomAttribute('zip_code'); // return "67890"
$lead->getCustomAttribute('no_exist_attr'); // return null讓他用起來比較不像是在寫sql query.
There was a problem hiding this comment.
有機會會看時程補上！！感謝建議！！
chenghung
approved these changes
May 31, 2023
chenghung
approved these changes
May 31, 2023
moon-brillar
force-pushed
the
3-setup-model-observer-traits-sti
branch
2 times, most recently
from
669b9c1 to
2762062
Compare
…e custom field values
moon-brillar
force-pushed
the
3-setup-model-observer-traits-sti
branch
from
e0495d2 to
f665dec
Compare
ericHao22
reviewed
Jun 1, 2023
| public function getValidationRule(): array | ||
| { | ||
| return [ | ||
| $this->key => ['date'], |
| ]; | ||
|
|
||
| protected static function newFactory(): Factory | ||
| { | ||
| return CustomFieldValueFactory::new(); | ||
| } | ||
|
|
||
| public function customField(): BelongsTo |
Comment on lines
+65
to
+75
| $query = CustomField::query(); | ||
| if (is_null($context)) { | ||
| $customFields = $query->get(); | ||
| } else { | ||
| $customFields = $query | ||
| ->where('contextable_type', get_class($context)) | ||
| ->where('contextable_id', $context->id) | ||
| ->get(); | ||
| } | ||
|
|
||
| return $customFields; |
There was a problem hiding this comment.
❗ change request
這邊應該會有一個共同條件是modal class才對？不管context有沒有存在都需要的條件，組成query應該會如下所示：
$query = CustomField::query();
$query->where('model_class', get_class($this));
if ($context) {
$query->where('contextable_type', get_class($context))
$query->where('contextable_id', $context->id);
}
return $query->get();There was a problem hiding this comment.
💬 comment
在拿多型關聯的class name時會建議用modal身上的getMorphClass去拿會比較好，因為多型關聯用的class name是可以客製的
$query->where('contextable_type', $context->getMorphClass());https://laravel.com/docs/8.x/eloquent-relationships#custom-polymorphic-types
There was a problem hiding this comment.
fixed, thanks!!
| $value = $validatedCustomFieldValues[$customField->key]; | ||
| $constraints = [ | ||
| 'custom_field_id' => $customField->id, | ||
| 'customizable_type' => get_class($this), |
| } | ||
| $customFields = $this->getCustomFields(); | ||
| $customFields->each(function ($customField) use ($validatedCustomFieldValues) { | ||
| if (array_key_exists($customField->key, $validatedCustomFieldValues)) { |
| $values = ['value' => $value]; | ||
| CustomFieldValue::updateOrCreate($constraints, $values); | ||
| } | ||
| }); |
There was a problem hiding this comment.
💬 comment
這裡更新完後要把$this->validatedCustomFieldValues清空嗎？
| /** | ||
| * @test | ||
| */ | ||
| public function custom_field_values_relationship_should_work(): void |
There was a problem hiding this comment.
💬 comment
感覺拿custom field value上面的測試多少有涵蓋到了，或許這裡可以著重測試搭配context拿custom fields的部份？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.