Fix custom fields conflict with standard columns #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericHao22
approved these changes
Jun 27, 2023
src/Concerns/Customizable.php
Outdated
| @@ -46,13 +46,11 @@ public function validateCustomFields(): void | |||
| if ($customFields->isEmpty()) { | |||
| return; | |||
| } | |||
| $modelAttributeKeys = $modelAttributes->keys(); | |||
| $customFieldColumns = $modelAttributeKeys->diff($tableColumns); | |||
| $externalCustomFields = $modelAttributes->get('custom'); | |||
There was a problem hiding this comment.
可能要考慮到custom key拿到的值是null的情況，下面的validator在呼叫make的時候可能只接受array
There was a problem hiding this comment.
💬 comment
好奇為什麼這個變數要加上external的前綴？感覺應該沒有內外部之分？
There was a problem hiding this comment.
其實我只是想表達從外部來還沒經過驗證的，我先改成 unvalidated
上面的已 fixed
| @@ -43,8 +43,8 @@ public function custom_field_values_relationship_should_work(): void | |||
| public function validate_custom_fields_should_work() | |||
| { | |||
| $this->expectException(ValidationException::class); | |||
| $this->user->zip_code = 123; | |||
| $this->user->validateCustomFields(); | |||
| $user = User::factory()->create(['account_id' => $this->account->id, 'custom' => ['zip_code' => 123]]); | |||
There was a problem hiding this comment.
💬 comment
這邊呼叫create的時候就會拋錯了，下面原本要測試的validateCustomFields方法還會呼叫到嗎？
There was a problem hiding this comment.
thanks! fixed!!!
…m key and load custom field value with the prefix custom
moon-brillar
force-pushed
the
10-custom-fields-conflict-with-standard-columns
branch
from
7e0899e to
ea27ed2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.