-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refine error msg: add NOLINT for defensive code in autograd #8525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjchen2
approved these changes
Jul 1, 2022
注意一下,需要将这些被改动过的文件中所有报错信息缺失的地方都改过来,才能通过need-check-error-message的检查 |
嗯,这个确认过,改动过的文件有 CHECK 的都改过了 |
zhongshsh
approved these changes
Jul 1, 2022
wyg1997
approved these changes
Jul 1, 2022
View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/8525/ |
Speed stats:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
// NOLINT(maybe-need-error-msg)
CHECK_NOTNULL_OR_RETURN(fw_op_expr);
CHECK_EQ_OR_RETURN(inputs.size(), xxx);
CHECK_EQ_OR_RETURN(outputs.size(), xxx);
CHECK_EQ_OR_RETURN(out_grads.size(), xxx);