-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename straighten algo interface #8495
Conversation
Co-authored-by: Yipeng Li <jamesonli1313@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good
@@ -278,15 +278,14 @@ def build(self, x): | |||
""" | |||
self.proto.cudnn_conv_heuristic_search_algo = mode | |||
|
|||
def disable_straighten_algorithm(self, mode: bool = False): | |||
r""" Whether we disable the straighten algorithm. | |||
def enable_straighten_algorithm(self, mode: bool = True): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个名字最好再精确一点,“拉直算法“作为代号ok,enable_dfs_op_schedule 是不是会更好一点?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
严格来说拉直不是dfs,
拉直算法不是纯dps,每有一次传输拉直就会从现有计算里面找节点来执行,这时候跑的是已经出现的节点,也就是深度小的。
可以说拉直在传输节点上是bfs,在传输节点间是dfs。
而且5_3_5只是拉直的其中一种模式,也可以选择纯粹的先进先出模式排序比如2_0_1,这时候也是bfs
Speed stats:
|
libai main分支有用这个接口吗?我好像没搜到? |
这个在 libai_bench_merge_main 和 libai_bench 分支下有 应该把 self.config.disable_straighten_algorithm(True) 修改为 self.config.enable_straighten_algorithm(False) 是么? |
|
根据讨论: https://github.com/Oneflow-Inc/OneTeam/issues/1509#issuecomment-1166820859 拉直算法默认并闭,并重命名接口: disable_straighten_algorithm -> enable_straighten_algorithm