This repository was archived by the owner on Apr 1, 2022. It is now read-only.
Fix sort arrow icon classes #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed that this assertion was failing about 50% of the time I ran the tests: It was inconsistent. It would pass sometimes, and fail others. I wasn't sure how to make sense of it. Since it passes sometimes, and seems to work correctly when I use these updates in my project, I thought I would submit the PR and see if you have experienced this same issue in the past. Even when I run the test suite with the master branch, I still see that test failing intermittently. Do you know what's causing that? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.