feat: send unattributed sessions to /outcomes/measure#1648
Open
feat: send unattributed sessions to /outcomes/measure#1648
Conversation
When the SDK was migrated from the player model, the /players/{id}/on_focus call was split into two requests: session time via Update User and session duration outcomes via `/outcomes/measure`. The outcomes half was only wired up for attributed sessions, so unattributed sessions never sent to `/outcomes/measure`. However, to get unattributed session data in the dashboard, unattributed sessions needed to be sent to `/outcomes/measure` as well.
- Remove END_SESSION guard in OSFocusTimeProcessorFactory that prevented creating an unattributed processor for session-end events
- Add sendSessionEndOutcomes call to OSUnattributedFocusTimeProcessor alongside sendSessionTime, matching the old model where both were always sent together
Verify the request parameters for unattributed (notification_ids omitted, direct: false), attributed direct (direct: true), and attributed indirect (direct: false) influence types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP: Confirm with analytics team on server load, otherwise PR changes are ready.
Description
One Line Summary
Send unattributed sessions to /outcomes/measure to show unattributed session data on dashboard.
Details
Motivation
Show unattributed session data on dashboard.
When the SDK was migrated from the player model, the
/players/{id}/on_focuscall was split into two requests: session time via Update User and session duration outcomes via /outcomes/measure. The outcomes half was only wired up for attributed sessions, so unattributed sessions never sent to /outcomes/measure, leaving unattributed session data missing from the dashboard.Changes:
Scope
Send unattributed session data to
/outcomes/measure, no change to attributed sessions or session time accumulation to update user endpoint.Testing
Unit testing
Manual testing
Tested on physical iOS 26 device
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is