Skip to content

[User Model] Provide serialization mechanism for external classes #1723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

brismithers
Copy link
Contributor

@brismithers brismithers commented Jan 18, 2023

  • Add ToJsonObject to NotificationClickResult, NotificationAction, and InAppMessageClickResult.
  • Expose groupedNotifications in INotification

This change is Reviewable

* Add ToJsonObject to NotificationClickResult, NotificationAction, and InAppMessageClickResult.
* Expose groupedNotifications in INotification
Copy link
Contributor

@shepherd-l shepherd-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @brismithers)

@brismithers brismithers merged commit 3453d43 into user-model/main Jan 19, 2023
@brismithers brismithers deleted the user-model/tojsonobject branch January 19, 2023 16:59
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
[User Model] Provide serialization mechanism for external classes
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
[User Model] Provide serialization mechanism for external classes
jinliu9508 pushed a commit that referenced this pull request Feb 6, 2024
[User Model] Provide serialization mechanism for external classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants