Skip to content

Add flag to modify the maximum amount of usable ServerLinks #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

Joltras
Copy link

@Joltras Joltras commented Oct 19, 2024

Proposed changes

The current maximum number of ServerLinks supported by the server is hardcoded into the specific packet structure. While this behavior is generally not an issue, it becomes problematic if a situation arises where a different limit is required, as it's not possible to adjust it. This pull request introduces a flag in the ServerFlag class, which can now be modified through a parameter.

Closes #83

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Copy link

@theEvilReaper
Copy link

In the future, we should add a test for the packet to verify the link amount limit. For now, though, it looks good

@theEvilReaper theEvilReaper merged commit 369e660 into master Oct 21, 2024
7 checks passed
@theEvilReaper theEvilReaper deleted the feature/flagForServerLinks branch October 21, 2024 17:57
TheMeinerLP pushed a commit that referenced this pull request Oct 31, 2024
* Add flag for the maximum amount of ServerLinks

* Update constant usage
TheMeinerLP pushed a commit that referenced this pull request Jan 6, 2025
* Add flag for the maximum amount of ServerLinks

* Update constant usage
@TheMeinerLP TheMeinerLP mentioned this pull request Jan 6, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Replace limits in packets with properties
2 participants