Skip to content

Commit 99238c2

Browse files
committed
[#34] Better Notification System (#35)
* [#34] Implement new notification system with tests * [#34] Update demo to use new notification system * [#34] Add deprecation text to old notification system * [#34] Improve javadocs and rename builder implementation * [#34] Improve javadocs and fix tests * [#34] Remove empty lines * [#34] Add package description
1 parent e7b85a0 commit 99238c2

File tree

1 file changed

+15
-10
lines changed

1 file changed

+15
-10
lines changed

demo/src/main/java/net/minestom/demo/PlayerInit.java

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55
import net.minestom.server.FeatureFlag;
66
import net.minestom.server.MinecraftServer;
77
import net.minestom.server.advancements.FrameType;
8-
import net.minestom.server.advancements.notifications.Notification;
9-
import net.minestom.server.advancements.notifications.NotificationCenter;
108
import net.minestom.server.adventure.MinestomAdventure;
119
import net.minestom.server.adventure.audience.Audiences;
1210
import net.minestom.server.coordinate.Pos;
@@ -24,7 +22,15 @@
2422
import net.minestom.server.event.entity.EntityAttackEvent;
2523
import net.minestom.server.event.item.ItemDropEvent;
2624
import net.minestom.server.event.item.PickupItemEvent;
27-
import net.minestom.server.event.player.*;
25+
import net.minestom.server.event.player.AsyncPlayerConfigurationEvent;
26+
import net.minestom.server.event.player.PlayerBlockInteractEvent;
27+
import net.minestom.server.event.player.PlayerBlockPlaceEvent;
28+
import net.minestom.server.event.player.PlayerDeathEvent;
29+
import net.minestom.server.event.player.PlayerDisconnectEvent;
30+
import net.minestom.server.event.player.PlayerPacketEvent;
31+
import net.minestom.server.event.player.PlayerPacketOutEvent;
32+
import net.minestom.server.event.player.PlayerSpawnEvent;
33+
import net.minestom.server.event.player.PlayerUseItemOnBlockEvent;
2834
import net.minestom.server.event.server.ServerTickMonitorEvent;
2935
import net.minestom.server.instance.Instance;
3036
import net.minestom.server.instance.InstanceContainer;
@@ -50,6 +56,7 @@
5056
import net.minestom.server.potion.CustomPotionEffect;
5157
import net.minestom.server.potion.PotionEffect;
5258
import net.minestom.server.sound.SoundEvent;
59+
import net.minestom.server.notifications.Notification;
5360
import net.minestom.server.utils.MathUtils;
5461
import net.minestom.server.utils.NamespaceID;
5562
import net.minestom.server.utils.time.TimeUnit;
@@ -183,13 +190,11 @@ class A {
183190

184191

185192
if (event.isFirstSpawn()) {
186-
Notification notification = new Notification(
187-
Component.text("Welcome!"),
188-
FrameType.TASK,
189-
Material.IRON_SWORD
190-
);
191-
NotificationCenter.send(notification, event.getPlayer());
192-
193+
Notification notification = Notification.builder()
194+
.frameType(FrameType.TASK)
195+
.title(Component.text("Welcome!"))
196+
.icon(Material.IRON_SWORD).build();
197+
notification.send(player);
193198
player.playSound(Sound.sound(SoundEvent.ENTITY_EXPERIENCE_ORB_PICKUP, Sound.Source.PLAYER, 0.5f, 1f));
194199
}
195200
})

0 commit comments

Comments
 (0)