Commit 587dc0d
committed
Simplified
The `closeModal` function had legacy parameters `action` and `namespace` which are no longer being used. The `action` hasn't been used in quite a while. The `namespace` was previously needed to determine the specific model window. This was replaced with the `[id^=""]` selector in a previous update, thus eliminating that need.
In addition, there's no need to call `modal('hide')` from _both_ the jQuery listener _and_ the `closeModal` function, so this is fixed. That was adding a bit of extra overhead which noticeably delayed the closing of the modal.closeModal definition1 parent 3218898 commit 587dc0d
File tree
1 file changed
+2
-5
lines changed1 file changed
+2
-5
lines changedLines changed: 2 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
75 | | - | |
76 | | - | |
77 | 75 | | |
78 | | - | |
| 76 | + | |
79 | 77 | | |
80 | 78 | | |
81 | 79 | | |
| |||
88 | 86 | | |
89 | 87 | | |
90 | 88 | | |
91 | | - | |
92 | | - | |
| 89 | + | |
93 | 90 | | |
94 | 91 | | |
95 | 92 | | |
| |||
0 commit comments