Update to MSBuild project model and fix for cross-targeting projects #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if this is ready to merge into dev? |
DustinCampbell
force-pushed
the
update-project-model
branch
from
d6daf1a
to
d845805
Compare
|
That ran locally grumble |
DustinCampbell
force-pushed
the
update-project-model
branch
3 times, most recently
from
4c762c7
to
b361033
Compare
david-driscoll
approved these changes
Dec 15, 2016
| { | ||
| // For now, we'll just pick the first target framework. Eventually, we'll need to | ||
| // do better and potentially allow OmniSharp hosts to select a target framework. | ||
| targetFramework = targetFrameworks[0]; |
There was a problem hiding this comment.
In the past we've exposed this on each request, but a dedicated endpoint would be ideal.
What about support in VScode? Any UI that might be setup?
There was a problem hiding this comment.
Eventually, yeah. Providing this on each request might prove very expensive.
DustinCampbell
force-pushed
the
update-project-model
branch
4 times, most recently
from
36ce9a2
to
ce473ec
Compare
DustinCampbell
force-pushed
the
update-project-model
branch
8 times, most recently
from
d601450
to
28ec64c
Compare
DustinCampbell
force-pushed
the
update-project-model
branch
from
28ec64c
to
0023a4c
Compare
This was referenced Dec 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of changes here, but the key pieces are: