Adds support for aliases on both ProjectReference and Reference #1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maybe you could test via |
|
Added tests (which verifies from workspace). ping @filipw |
This was referenced Feb 14, 2020
filipw
added a commit
that referenced
this pull request
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation (alias on
Reference) may or may not have worked previously. It's hard to know as the tests only checks that the values are present in theProjectFileInfo. It currently lacks tests inProjectManager, which is where the logic resides for actually adding the alias to the reference (Project or Metadata).This PR also adds support for aliases on
ProjectReference.I don't think we have any tests on
ProjectManagerat this point, but should I just att a simple test that verifies that there are no errors in the test-projects that currently use aliases for references? That's a quick way to ensure we don't break this in the future.