Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rationalize OmniSharp versions #757

Open
DustinCampbell opened this issue Feb 6, 2017 · 8 comments
Open

Rationalize OmniSharp versions #757

DustinCampbell opened this issue Feb 6, 2017 · 8 comments

Comments

@DustinCampbell
Copy link
Contributor

Today, the only notion of version in OmniSharp are the releases and tags on GitHub. However, that isn't reflected in the assembly versions. It would be ideal if assemblies were properly stamped with a version and the version was displayed on OmniSharp launch.

@filipw
Copy link
Member

filipw commented Feb 6, 2017

+1000

Also, branch dev should go in favor of just master.
And the versions we release from GH should just be regular semantic versions - i.e. 2.0.0, 2.1.0, and so on.

@DustinCampbell
Copy link
Contributor Author

Yeah, I think the only thing holding us up is that we're all a little confused as to what constitutes 2.0.0. Where should we call it ready? For example, should we wait until we're off project.json? Should we wait until we drop .NET Core standalone releases? Should we wait until we drop the http infrastructure and make it a plugin?

@filipw
Copy link
Member

filipw commented Feb 6, 2017

Right, then let's call it 1.10.0, 1.11.0 and so on - until there is an clear view of what constitutes OmniSharp 2.

@david-driscoll
Copy link
Member

I've had good success with GitVersion in other projects, atleast that helps with stamping versions.

@DustinCampbell
Copy link
Contributor Author

Right, then let's call it 1.10.0, 1.11.0 and so on - until there is an clear view of what constitutes OmniSharp 2.

Makes sense to me.

@david-driscoll
Copy link
Member

the new csproj makes this even easier now, as there is a new task that generates all the assembly attributes for you..

@DustinCampbell
Copy link
Contributor Author

Cool. That gives me incentive to get back to making the macOS/Linux builds work on .csproj.

@DustinCampbell
Copy link
Contributor Author

Now that the dev branch is gone, I think we only need to get version stamping going to address this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants