From 6a54aeb95359a521b859276e780c5c369090e628 Mon Sep 17 00:00:00 2001 From: tahir-khalid Date: Wed, 16 Oct 2024 09:46:13 +0100 Subject: [PATCH] PR comments --- app/controllers/concerns/cookies_concern.rb | 14 ++++++-------- app/views/layouts/application.html.erb | 4 ++-- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/app/controllers/concerns/cookies_concern.rb b/app/controllers/concerns/cookies_concern.rb index e485a5c979..333e701188 100644 --- a/app/controllers/concerns/cookies_concern.rb +++ b/app/controllers/concerns/cookies_concern.rb @@ -45,14 +45,12 @@ def set_analytics_cookies(accept_analytics_cookies) cookies[:accept_analytics_cookies] = { value: accept_analytics_cookies, expires: 1.year.from_now } cookies[:cookie_preferences_set] = { value: accept_analytics_cookies, expires: 1.year.from_now } - if accept_analytics_cookies == true - cookies[:cookies_policy] = { - value: get_policy.to_json, - expires: 1.year.from_now, - httponly: true, - raw: true - } - end + cookies[:cookies_policy] = { + value: get_policy.to_json, + expires: 1.year.from_now, + httponly: true, + raw: true + } end private diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb index e4250e6941..8b3bd2b5b9 100644 --- a/app/views/layouts/application.html.erb +++ b/app/views/layouts/application.html.erb @@ -14,12 +14,12 @@ <%= javascript_include_tag "application", type: "module", nonce: true %> <%= stylesheet_link_tag "application" %> <%= csrf_meta_tags %> - <% if !Rails.env.development? %> + <% unless Rails.env.development? %> <%= render "shared/ga_head" %> <% end %> - <% if !Rails.env.development? %> + <% unless Rails.env.development? %> <%= render "shared/ga_body" %> <% end %> <%= javascript_tag nonce: true do -%>