-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(da): filter underscores of namespace in ai-plugin during build #13391
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/5.14 #13391 +/- ##
==============================================
Coverage 90.35% 90.36%
==============================================
Files 619 619
Lines 36979 36985 +6
Branches 7181 7340 +159
==============================================
+ Hits 33414 33420 +6
Misses 1535 1535
Partials 2030 2030
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This pull request addresses a performance improvement by filtering out underscores from the namespace in the ai-plugin during the build process. Key changes include:
- A new test case verifying that namespaces with underscores are correctly filtered.
- Modifications in the build process to remove underscores from the plugin file’s namespace and log a warning.
- Adjustments to temporary file generation for cases with underscores or external adaptive cards.
Reviewed Changes
File | Description |
---|---|
packages/fx-core/tests/component/driver/teamsApp/createAppPackage.test.ts | Added a test case to validate underscore filtering and the resulting content in the generated zip file |
packages/fx-core/src/component/driver/teamsApp/createAppPackage.ts | Introduced logic to remove underscores from namespace and log a warning when filtering occurs |
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
packages/fx-core/tests/component/driver/teamsApp/createAppPackage.test.ts:1130
- [nitpick] The assertion error message is misleading; it refers to 'plugin_namespace' while the expected substring is 'pluginnamespace'. Consider updating the message to more clearly indicate that underscores have been removed.
chai.assert.include(aiPluginContent, "pluginnamespace", "plugin_namespace not replaced");
packages/fx-core/tests/component/driver/teamsApp/createAppPackage.test.ts:1132
- [nitpick] The assertion message 'file not replaced' could be more descriptive to clarify that it checks for the removal of an unintended literal substring. Consider revising the message to improve clarity.
chai.assert(aiPluginContent.search("file") < 0, "file not replaced");
No description provided.