Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Known Issue] SSO in Tab does not work with error "performanceMeasurement.startMeasurement is not a function" #7562

Open
KennethBWSong opened this issue Jan 18, 2023 · 6 comments
Assignees
Labels
upstream The issue is tracked external dependency

Comments

@KennethBWSong
Copy link
Contributor

Describe the bug
'SSO-enabled Tab' cannot properly show user profile after click 'Authorize'. In Dev Tools, will show error "performanceMeasurement.startMeasurement is not a function".

To Reproduce
Steps to reproduce the behavior:

  1. Create a 'SSO-enabled Tab'
  2. F5 to local debug
  3. Click on 'Authorize'
  4. User profile will not properly show

Expected behavior
User profile can correctly show.

VS Code Extension Information (please complete the following information):

  • Teams Toolkit version: 4.2.1
  • msal-browser version: 2.32.2

Workaround

  1. Go to {your-project-path}/tabs
  2. Run following command:
    npm i @azure/msal-browser@2.32.1
    
  3. Run local-debug or 'deploy' again

Root Cause
You can refer to this issue for more context.

@ghost
Copy link

ghost commented Jan 18, 2023

Thank you for contacting us! Any issue or feedback from you is quite important to us. We will do our best to fully respond to your issue as soon as possible. Sometimes additional investigations may be needed, we will usually get back to you within 2 days by adding comments to this issue. Please stay tuned.

@KennethBWSong KennethBWSong pinned this issue Jan 18, 2023
@blackchoey blackchoey added the upstream The issue is tracked external dependency label Jan 18, 2023
@Mimetis
Copy link

Mimetis commented Jan 19, 2023

Thanks @KennethBWSong
You saved my day, as I was struggling with this annoying performanceMeasurement.startMeasurement is not a function bug during the last couple of hours ...

@ghost ghost added the needs attention This issue needs the attention of a contributor. label Jan 19, 2023
@rbkharade
Copy link

Hi @Mimetis / @KennethBWSong , can you please let me know what was the issue here ? I am also facing the same error for SPFx .

@Mimetis
Copy link

Mimetis commented Jan 19, 2023

@rbkharade I think the issue explains what the problem is, doesn't it ?

In a Teams application, you may have an error of type "performanceMeasurement.startMeasurement is not a function" when trying to retrieve a user's profile
The solution is to add the package @azure/msal-browser@2.32.1 directly in the teams tab project

@rbkharade
Copy link

@Mimetis , thank you for the prompt response. I was using @azure/msal-browser with version "^2.25.0" and somehow it was installing 2.32.2 as its the latest stable one. The issue might be associated with the latest version of "@azure/msal-browser". I will try to downgrade it and check it.

@adashen adashen removed the needs attention This issue needs the attention of a contributor. label Jan 30, 2023
@garrytrinder
Copy link

Same error.

I can confirm that @Mimetis solution to install @azure/msal-browser@2.32.1 directly in the tab project works.

Thanks for sharing.

@ghost ghost added the needs attention This issue needs the attention of a contributor. label Feb 7, 2023
@adashen adashen removed the needs attention This issue needs the attention of a contributor. label Feb 8, 2023
@wenytang-ms wenytang-ms unpinned this issue Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream The issue is tracked external dependency
Projects
None yet
Development

No branches or pull requests

6 participants