Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sample Onboard Request] Policies Graph connector #1323

Open
waldekmastykarz opened this issue Sep 4, 2024 · 12 comments
Open

[Sample Onboard Request] Policies Graph connector #1323

waldekmastykarz opened this issue Sep 4, 2024 · 12 comments
Assignees
Labels
reviewed reviewed sample PR test passed sample pass test

Comments

@waldekmastykarz
Copy link
Contributor

Owner:

@waldekmastykarz
@sebastienlevert

ID:
nodejs-typescript-policies

Title:
Policies Graph connector

Description:
This sample project uses Teams Toolkit for Visual Studio Code to simplify the process of creating a Microsoft Graph connector that ingests data from a custom API to Microsoft Graph. It provides an end to end example of creating the connector, ingesting content and refreshing the ingested content.

Tags:
TS, Graph connect, Azure Function, Copilot for Microsoft 365

Time:
10 mins to run

Configuration:
Ready for local debug

Thumbnail:
https://raw.githubusercontent.com/pnp/graph-connectors-samples/main/samples/nodejs-typescript-policies/assets/connector-copilot-results.png

(Source code NOT in this Repo) Sample URL:
https://github.com/pnp/graph-connectors-samples/blob/main/samples/nodejs-typescript-policies/

@summzhan
Copy link
Contributor

summzhan commented Sep 5, 2024

@waldekmastykarz Thanks for following our process, I will help you review and go through the testing process.

@formulahendry formulahendry added the testing testing sample by following README label Sep 9, 2024
@summzhan summzhan added the reviewed reviewed sample PR label Sep 9, 2024
@summzhan
Copy link
Contributor

summzhan commented Sep 9, 2024

@waldekmastykarz , I have reviewed your sample and it looks good to me, this sample is under checking by our testing team now. Still needs time for their feedback.

Only one minor suggestion is that in README file, it is better to put "Features" section right after sample "Summary" section:
image
image

Since people may want to understand the features first before they hands on to play with it. Also, it will make this sample looks more aligned with other samples in sample gallery regarding to the README structure.

@waldekmastykarz
Copy link
Contributor Author

That's a great suggestion. I'll update it. Thank you

@waldekmastykarz
Copy link
Contributor Author

Readme updated

@hellyzh
Copy link
Collaborator

hellyzh commented Sep 13, 2024

@waldekmastykarz , I'd like to run the test for the sample but has no copilot access for my m365 test account. The MS tenant account has copilot access but has no access for Microsoft 365 admin portal. So the test is blocked. Do you know how to get the copilot access for my m365 test account?

@waldekmastykarz
Copy link
Contributor Author

@hellyzh Sorry, I don't. To run the sample you don't necessarily need Copilot. This sample only contains a Graph connector. You can run the sample to ingest the content to your tenant. When it's done, you can verify that the content has been properly ingested via Microsoft 365 Search.

@hellyzh
Copy link
Collaborator

hellyzh commented Sep 23, 2024

@waldekmastykarz We can run the sample according to the readme, but are still not able to validate the result. The result in copilot by navigating to Microsoft365.com/chat is showing as below. The content looks like not the one in readme.
image
If use Microsoft 365 Search to verify the content, no content can be found. I have set the Required actions column with selecting the link to Include Connector Results and confirm the prompt.
image

@waldekmastykarz
Copy link
Contributor Author

Since we've updated the sample to only include the Graph connector without a declarative agent, let me update the instructions to make that more clear. Sorry for the trouble and I appreciate your patience. I'll post an update when the sample is ready for a retest.

@waldekmastykarz
Copy link
Contributor Author

I've updated the instructions and the sample is ready for retesting. Please let me know if I can help with anything

@Annefch Annefch added test passed sample pass test and removed testing testing sample by following README labels Sep 25, 2024
@tecton
Copy link
Contributor

tecton commented Oct 8, 2024

@summzhan Please help to define the type of this sample.

@summzhan
Copy link
Contributor

@summzhan Please help to define the type of this sample.

@tecton I cannot tell either, @waldekmastykarz could you please tell us the type of this sample? like tab or bot or what else.

@waldekmastykarz
Copy link
Contributor Author

It's a Microsoft Graph connector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed reviewed sample PR test passed sample pass test
Projects
None yet
Development

No branches or pull requests

7 participants
@tecton @formulahendry @waldekmastykarz @Annefch @hellyzh @summzhan and others